Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2231)

Unified Diff: chrome/browser/chromeos/file_manager/file_tasks.cc

Issue 2576833002: Make some updates to extension iconography. (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/file_tasks.cc
diff --git a/chrome/browser/chromeos/file_manager/file_tasks.cc b/chrome/browser/chromeos/file_manager/file_tasks.cc
index 1079d744510de8fc0b46e8bc79b8faaa34266bc7..18bab7b2c4e24a46ef72f548653dacea85d84c44 100644
--- a/chrome/browser/chromeos/file_manager/file_tasks.cc
+++ b/chrome/browser/chromeos/file_manager/file_tasks.cc
@@ -503,8 +503,7 @@ void FindFileHandlerTasks(Profile* profile,
GURL best_icon = extensions::ExtensionIconSource::GetIconURL(
extension, drive::util::kPreferredIconSize,
ExtensionIconSet::MATCH_BIGGER,
- false, // grayscale
- NULL); // exists
+ false); // exists
Devlin 2016/12/15 17:14:40 The remaining bool is grayscale, not exists, right
Evan Stade 2016/12/15 23:49:02 Done.
// If file handler doesn't match as good match, regards it as generic file
// handler.
@@ -559,11 +558,9 @@ void FindFileBrowserHandlerTasks(
// TODO(zelidrag): Figure out how to expose icon URL that task defined in
// manifest instead of the default extension icon.
const GURL icon_url = extensions::ExtensionIconSource::GetIconURL(
- extension,
- extension_misc::EXTENSION_ICON_BITTY,
+ extension, extension_misc::EXTENSION_ICON_BITTY,
ExtensionIconSet::MATCH_BIGGER,
- false, // grayscale
- NULL); // exists
+ false); // exists
result_list->push_back(FullTaskDescriptor(
TaskDescriptor(extension_id, file_tasks::TASK_TYPE_FILE_BROWSER_HANDLER,

Powered by Google App Engine
This is Rietveld 408576698