Make some updates to extension iconography.

Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259, 596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93
Cr-Commit-Position: refs/heads/master@{#439361}

[Evan Stade, 2016-12-14 20:18:21]

Description was changed from

==========
WIP

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
==========

to

==========
WIP

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Evan Stade, 2016-12-15 03:04:13]

Description was changed from

==========
WIP

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Evan Stade, 2016-12-15 03:04:13]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org, pkasting@chromium.org, rdevlin.cronin@chromium.org

[Evan Stade, 2016-12-15 03:07:08]

Sorry for large patchset. The rabbit hole went deep on this one.

+pkasting for *omnibox* files (bullet point 1)
+devlin for *extensions* files (bullet point 2)
+dbeam for *webui* and *resources* files (bullet point 3)

[Peter Kasting, 2016-12-15 07:54:26]

I get the easy review!  *omnibox* LGTM

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/ui/omnib...
File chrome/browser/ui/omnibox/chrome_omnibox_client.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/ui/omnib...
chrome/browser/ui/omnibox/chrome_omnibox_client.cc:51: #include
"third_party/skia/include/core/SkBitmap.h"
Nit: Is this an IWYU change?

[Evan Stade, 2016-12-15 17:14:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 17:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-12-15 17:14:41]

Nice!  Mostly just nits.

Could you also add a screenshot of the before/after to one of the bugs?

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/file_tasks.cc:506: false);  // exists
The remaining bool is grayscale, not exists, right?

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager.cc:52: if
(base::ContainsKey(icons_, extension_id)) {
not your code, but this does a double lookup.  Can you change it to be
auto iter = icons_.find(extension_id);
if (iter != icons_.end()) {
  result = &iter->second;
else {
  EnsureDefaultIcon();
  result = &default_icon_;
}
?

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager.cc:77: if
(!base::ContainsKey(pending_icons_, extension_id))
ditto re double lookup

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager_unittest.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:197:
std::unique_ptr<Profile> profile(new TestingProfile());
nit: I think we prefer MakeUnique now, so
auto profile = base::MakeUnique<TestingProfile>();

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:233:
SCOPED_TRACE(testing::Message() << "Test case: " << i);
mind blown.  Had no idea this existed.  Awesome.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:259: for (int dsf =
ui::SCALE_FACTOR_NONE + 1; dsf < ui::NUM_SCALE_FACTORS;
what is dsf?

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/menu_manager.h (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/menu_manager.h:347: // This returns a bitmap of
width/height kFaviconSize, loaded either from an
nit: update (no longer returns a bitmap)

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/menu_manager.h:350: gfx::Image
GetIconForExtension(const std::string& extension_id);
nit: iwyu

https://codereview.chromium.org/2576833002/diff/20001/chrome/test/data/extens...
File chrome/test/data/extensions/context_menus/icons/sample.js (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/context_menus/icons/sample.js:1: // Copyright (c)
2010 The Chromium Authors. All rights reserved.
not 2010

https://codereview.chromium.org/2576833002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/context_menus/icons/sample.js:4: 
I just realized this whole file was copy-pasted.  Feel free to ignore all the
nits here and add a
// TODO(devlin): This file can be improved, and was copied from public docs.
Clean both up.

https://codereview.chromium.org/2576833002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/context_menus/icons/sample.js:7: console.log("item "
+ info.menuItemId + " was clicked");
nit: prefer single quotes in js

https://codereview.chromium.org/2576833002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/context_menus/icons/sample.js:15: for (var i = 0; i
< contexts.length; i++) {
for (let context of contexts)?

https://codereview.chromium.org/2576833002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/context_menus/icons/sample.js:18: var id =
chrome.contextMenus.create({"title": title, "contexts":[context],
nit: no quotes around keys in objects.
nit: add a space after the ':' (next to contexts)

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
File extensions/browser/image_loader.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
extensions/browser/image_loader.cc:252: extensions::ExtensionResource image =
no need for extensions:: prefix

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
File extensions/browser/image_loader.h (right):

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
extensions/browser/image_loader.h:84: // and rename the later to LoadImageAsync.
s/later/latter

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
extensions/browser/image_loader.h:93: const extensions::Extension* extension,
no need for extensions:: prefix.

[commit-bot: I haz the power, 2016-12-15 17:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 17:26:29]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Evan Stade, 2016-12-15 23:49:02]

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/file_tasks.cc:506: false);  // exists
On 2016/12/15 17:14:40, Devlin wrote:
> The remaining bool is grayscale, not exists, right?

Done.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager.cc:52: if
(base::ContainsKey(icons_, extension_id)) {
On 2016/12/15 17:14:41, Devlin wrote:
> not your code, but this does a double lookup.  Can you change it to be
> auto iter = icons_.find(extension_id);
> if (iter != icons_.end()) {
>   result = &iter->second;
> else {
>   EnsureDefaultIcon();
>   result = &default_icon_;
> }
> ?

Done.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager.cc:77: if
(!base::ContainsKey(pending_icons_, extension_id))
On 2016/12/15 17:14:41, Devlin wrote:
> ditto re double lookup

Done.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager_unittest.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:197:
std::unique_ptr<Profile> profile(new TestingProfile());
On 2016/12/15 17:14:41, Devlin wrote:
> nit: I think we prefer MakeUnique now, so
> auto profile = base::MakeUnique<TestingProfile>();

Done.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:233:
SCOPED_TRACE(testing::Message() << "Test case: " << i);
On 2016/12/15 17:14:41, Devlin wrote:
> mind blown.  Had no idea this existed.  Awesome.

Acknowledged.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:259: for (int dsf =
ui::SCALE_FACTOR_NONE + 1; dsf < ui::NUM_SCALE_FACTORS;
On 2016/12/15 17:14:41, Devlin wrote:
> what is dsf?

stands for device scale factor. Changed to scale_factor_iter

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/menu_manager.h (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/menu_manager.h:347: // This returns a bitmap of
width/height kFaviconSize, loaded either from an
On 2016/12/15 17:14:41, Devlin wrote:
> nit: update (no longer returns a bitmap)

Done.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/menu_manager.h:350: gfx::Image
GetIconForExtension(const std::string& extension_id);
On 2016/12/15 17:14:41, Devlin wrote:
> nit: iwyu

Done.

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/ui/omnib...
File chrome/browser/ui/omnibox/chrome_omnibox_client.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/chrome/browser/ui/omnib...
chrome/browser/ui/omnibox/chrome_omnibox_client.cc:51: #include
"third_party/skia/include/core/SkBitmap.h"
On 2016/12/15 07:54:26, Peter Kasting wrote:
> Nit: Is this an IWYU change?

more or less. It was relying on a transitive include.

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
File extensions/browser/image_loader.cc (right):

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
extensions/browser/image_loader.cc:252: extensions::ExtensionResource image =
On 2016/12/15 17:14:41, Devlin wrote:
> no need for extensions:: prefix

Done.

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
File extensions/browser/image_loader.h (right):

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
extensions/browser/image_loader.h:84: // and rename the later to LoadImageAsync.
On 2016/12/15 17:14:41, Devlin wrote:
> s/later/latter

Done.

https://codereview.chromium.org/2576833002/diff/20001/extensions/browser/imag...
extensions/browser/image_loader.h:93: const extensions::Extension* extension,
On 2016/12/15 17:14:41, Devlin wrote:
> no need for extensions:: prefix.

Done.

[Evan Stade, 2016-12-15 23:49:27]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-16 01:01:23]

lgtm

https://codereview.chromium.org/2576833002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/ntp4/page_list_view.js (right):

https://codereview.chromium.org/2576833002/diff/60001/chrome/browser/resource...
chrome/browser/resources/ntp4/page_list_view.js:24: *           
icon_small_exists: boolean,
did you mean to remove icon_small* out of curiosity?

[commit-bot: I haz the power, 2016-12-16 01:40:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:40:38]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-12-16 02:08:12]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 02:09:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 06:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 06:01:29]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-16 19:54:55]

lgtm

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/file_tasks.cc:563: false);  // exists
s/exists/grayscale

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager.h (right):

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager.h:25: class Image;
nit: no longer needed

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager_unittest.cc (right):

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:216: int
kMaxIconSizeInManifest = 32;
nitty nit: the kFoo naming implies this should be const int.

[Evan Stade, 2016-12-16 21:36:43]

Description was changed from

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Evan Stade, 2016-12-16 21:36:43]

estade@chromium.org changed reviewers:
+ kinaba@chromium.org

[Evan Stade, 2016-12-16 21:37:04]

TBR kinaba@ for mechanical change to file_tasks.cc

https://codereview.chromium.org/2576833002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/ntp4/page_list_view.js (right):

https://codereview.chromium.org/2576833002/diff/60001/chrome/browser/resource...
chrome/browser/resources/ntp4/page_list_view.js:24: *           
icon_small_exists: boolean,
On 2016/12/16 01:01:23, Dan Beam wrote:
> did you mean to remove icon_small* out of curiosity?

yes, I should do that. Done.

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/file_tasks.cc:563: false);  // exists
On 2016/12/16 19:54:54, Devlin wrote:
> s/exists/grayscale

Done.

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager.h (right):

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager.h:25: class Image;
On 2016/12/16 19:54:54, Devlin wrote:
> nit: no longer needed

Done.

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/extension_icon_manager_unittest.cc (right):

https://codereview.chromium.org/2576833002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/extension_icon_manager_unittest.cc:216: int
kMaxIconSizeInManifest = 32;
On 2016/12/16 19:54:54, Devlin wrote:
> nitty nit: the kFoo naming implies this should be const int.

Done.

[Evan Stade, 2016-12-16 21:37:17]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-16 21:37:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, dbeam@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2576833002/#ps100001
(title: "devlin review")

[commit-bot: I haz the power, 2016-12-16 21:38:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 23:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:41:11]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[kinaba, 2016-12-16 23:59:04]

file_manager lgtm

[Evan Stade, 2016-12-17 23:57:37]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-12-17 23:57:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 01:26:21]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482019057981720,
"parent_rev": "353c90afbc934d43dee90327a099556728b6926e", "commit_rev":
"a0ab929e7fafb79def391bc84a90a8d303dbdfe2"}

[commit-bot: I haz the power, 2016-12-18 01:27:24]

Description was changed from

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576833002
==========

[commit-bot: I haz the power, 2016-12-18 01:27:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-18 01:30:18]

Description was changed from

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576833002
==========

to

==========
Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG=674259,596757
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93
Cr-Commit-Position: refs/heads/master@{#439361}
==========

[commit-bot: I haz the power, 2016-12-18 01:30:19]

Patchset 6 (id:??) landed as
https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93
Cr-Commit-Position: refs/heads/master@{#439361}