Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2576813002: Disable WEBGL_compressed_texture_etc1 on WebGL 1 on ANGLE (Closed)

Created:
4 years ago by Kai Ninomiya
Modified:
4 years ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ETC1 textures on WebGL 1 on ANGLE BUG=658929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3e4c260ba044f3820a082c5bdb2336f837a4a841 Cr-Commit-Position: refs/heads/master@{#438638}

Patch Set 1 #

Patch Set 2 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 chunks +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC1.cpp View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Kai Ninomiya
zmo, PTAL
4 years ago (2016-12-14 19:37:42 UTC) #4
Zhenyao Mo
On 2016/12/14 19:37:42, Kai Ninomiya wrote: > zmo, PTAL lgtm
4 years ago (2016-12-14 19:52:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576813002/20001
4 years ago (2016-12-14 21:43:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 21:50:38 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 21:53:08 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e4c260ba044f3820a082c5bdb2336f837a4a841
Cr-Commit-Position: refs/heads/master@{#438638}

Powered by Google App Engine
This is Rietveld 408576698