Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2576793002: cc: Add rtree perftests. (Closed)

Created:
4 years ago by vmpstr
Modified:
4 years ago
Reviewers:
danakj, DmitrySkiba
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add rtree perftests. This patch adds some perftests to measure RTree performance. Sample run (on z620): [==========] Running 2 tests from 1 test case. [----------] Global test environment set-up. [----------] 2 tests from RTreePerfTest [ RUN ] RTreePerfTest.Construct *RESULT rtree_construct: 100= 346091.53125 runs/s *RESULT rtree_construct: 1000= 36854.61328125 runs/s *RESULT rtree_construct: 10000= 3392.330322265625 runs/s *RESULT rtree_construct: 100000= 369.79052734375 runs/s [ OK ] RTreePerfTest.Construct (8040 ms) [ RUN ] RTreePerfTest.Search *RESULT rtree_search: 100= 2992395.5 runs/s *RESULT rtree_search: 1000= 507624.9375 runs/s *RESULT rtree_search: 10000= 32956.60546875 runs/s *RESULT rtree_search: 100000= 3477.254638671875 runs/s [ OK ] RTreePerfTest.Search (8020 ms) [----------] 2 tests from RTreePerfTest (16060 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test case ran. (16060 ms total) [ PASSED ] 2 tests. R=danakj@chromium.org, dskiba@chromium.org BUG=674169 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/0d69452813c95ee10e53b8e83eaceea23a2b1780 Cr-Commit-Position: refs/heads/master@{#438675}

Patch Set 1 #

Patch Set 2 : rtreefix: remove_unittest #

Total comments: 2

Patch Set 3 : rtreefix: large_query #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -1 line) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/DEPS View 1 chunk +5 lines, -1 line 0 comments Download
A cc/base/rtree_perftest.cc View 1 2 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
vmpstr
Behold, a patch!
4 years ago (2016-12-14 19:26:16 UTC) #2
vmpstr
4 years ago (2016-12-14 19:26:44 UTC) #5
danakj
LGTM https://codereview.chromium.org/2576793002/diff/20001/cc/base/rtree_perftest.cc File cc/base/rtree_perftest.cc (right): https://codereview.chromium.org/2576793002/diff/20001/cc/base/rtree_perftest.cc#newcode41 cc/base/rtree_perftest.cc:41: gfx::Rect(-10, -10, 1, 1), gfx::Rect(0, 0, 1000, 1000)}; ...
4 years ago (2016-12-14 20:36:44 UTC) #6
vmpstr
https://codereview.chromium.org/2576793002/diff/20001/cc/base/rtree_perftest.cc File cc/base/rtree_perftest.cc (right): https://codereview.chromium.org/2576793002/diff/20001/cc/base/rtree_perftest.cc#newcode41 cc/base/rtree_perftest.cc:41: gfx::Rect(-10, -10, 1, 1), gfx::Rect(0, 0, 1000, 1000)}; On ...
4 years ago (2016-12-14 20:43:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576793002/40001
4 years ago (2016-12-14 20:44:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/199362)
4 years ago (2016-12-14 22:30:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576793002/40001
4 years ago (2016-12-14 22:46:53 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-14 23:37:53 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-14 23:39:34 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d69452813c95ee10e53b8e83eaceea23a2b1780
Cr-Commit-Position: refs/heads/master@{#438675}

Powered by Google App Engine
This is Rietveld 408576698