Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2576753002: Remove some more private script related things (Closed)

Created:
4 years ago by adithyas
Modified:
4 years ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some more private script related things I missed out on removing a few things in http://crrev.com/2571063002, which I've cleaned up here. BUG=673844 Committed: https://crrev.com/6414a1533148a728cd1c701a81b07abdc93f87da Cr-Commit-Position: refs/heads/master@{#439011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/marquee-named-property-crash.html View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/editing/js/DocumentExecCommand.js View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
adithyas
4 years ago (2016-12-14 20:44:56 UTC) #5
jbroman
lgtm
4 years ago (2016-12-14 20:46:41 UTC) #6
haraken
LGTM
4 years ago (2016-12-14 23:54:19 UTC) #9
adithyas
+alph@ for devtools/front_end review
4 years ago (2016-12-15 15:43:23 UTC) #11
alph
+pfeldman
4 years ago (2016-12-15 23:17:05 UTC) #13
pfeldman
lgtm
4 years ago (2016-12-16 00:04:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576753002/1
4 years ago (2016-12-16 00:09:46 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 03:55:54 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-16 03:57:59 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6414a1533148a728cd1c701a81b07abdc93f87da
Cr-Commit-Position: refs/heads/master@{#439011}

Powered by Google App Engine
This is Rietveld 408576698