|
|
Revert of Restrict transmission of external exp ids to signed in users. (patchset #1 id:1 of https://codereview.chromium.org/2569403003/ )
Reason for revert:
Merge conflict error.
Original issue's description:
> Restrict transmission of external exp ids to signed in users.
>
> Since external experiment ids are not based on Chrome's low
> entropy source, they do not have the same guarantees about
> not identifying a user as Chrome's variations. As such, we
> should only transmit them for signed in users, whose identity
> is already known by Google so there's no risk of identifying
> them through these headers.
>
> Note: The signed-in state checking in this CL is only done for
> web content area requests and not other internal requests,
> like to the suggestion service, where it treats the state as
> "not signed in". This is fine to do because variations service
> ids are still sent, which is what the other call sites are
> interested in.
>
> BUG= 672532
> TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org
>
> Review-Url: https://codereview.chromium.org/2558913003
> Cr-Commit-Position: refs/heads/master@{#437959}
> (cherry picked from commit 9ed7b5611a61505c3dba734fe55b92211df3c2f6)
TBR=afakhry@chromium.org,donnd@chromium.org,mattm@chromium.org,mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 672532
Review-Url: https://codereview.chromium.org/2576733002
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+135 lines, -244 lines) |
Patch |
 |
M |
chrome/browser/android/contextualsearch/contextual_search_delegate.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/android/metrics/uma_session_stats.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/safe_browsing/srt_fetcher_win.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/autofill_download_manager.cc
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/feedback/feedback_uploader_chrome.cc
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/ntp_snippets/remote/ntp_snippets_fetcher.cc
|
View
|
|
1 chunk |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
components/omnibox/browser/search_provider.cc
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/omnibox/browser/zero_suggest_provider.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
components/suggestions/suggestions_service.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
components/variations/net/variations_http_headers.h
|
View
|
|
1 chunk |
+3 lines, -7 lines |
0 comments
|
Download
|
 |
M |
components/variations/net/variations_http_headers.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
components/variations/variations_associated_data.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/variations/variations_associated_data.cc
|
View
|
|
1 chunk |
+7 lines, -15 lines |
0 comments
|
Download
|
 |
M |
components/variations/variations_http_header_provider.h
|
View
|
|
4 chunks |
+13 lines, -27 lines |
0 comments
|
Download
|
 |
M |
components/variations/variations_http_header_provider.cc
|
View
|
|
9 chunks |
+86 lines, -110 lines |
0 comments
|
Download
|
 |
M |
components/variations/variations_http_header_provider_unittest.cc
|
View
|
|
4 chunks |
+11 lines, -32 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|