Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: url/DEPS

Issue 257673002: Make it possible to build url/ without ICU on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix GN/GYP Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: url/DEPS
diff --git a/url/DEPS b/url/DEPS
new file mode 100644
index 0000000000000000000000000000000000000000..9643291a465c3ae4531273519b20784f72f1df7c
--- /dev/null
+++ b/url/DEPS
@@ -0,0 +1,13 @@
+include_rules = [
+ "+jni",
mef 2014/05/01 19:45:15 what about non-android platforms? does it make sen
mmenke 2014/05/01 21:01:33 DEPS files aren't per-platform, and aren't used fo
mef 2014/05/02 15:10:48 sgtm
+
+ # Limit files that can depend on icu.
+ "-base/i18n",
+ "-third_party/icu",
+]
+
+specific_include_rules = {
+ "url_canon_icu(\.cc|_unittest\.cc)": [
+ "+third_party/icu",
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698