url/DEPS - Issue 257673002: Make it possible to build url/ without ICU on android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: url/DEPS

Issue 257673002: Make it possible to build url/ without ICU on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix GN/GYP Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+jni",
	mef 2014/05/01 19:45:15 what about non-android platforms? does it make sen what about non-android platforms? does it make sense for them to depend on jni? mmenke 2014/05/01 21:01:33 DEPS files aren't per-platform, and aren't used fo Show quoted text On 2014/05/01 19:45:15, mef wrote: > what about non-android platforms? does it make sense for them to depend on jni? DEPS files aren't per-platform, and aren't used for figuring out what to build. Instead, they're static checks run on includes. We could do per-file deps, but I'm not sure we get anything out of it. Net does the exact same thing. mef 2014/05/02 15:10:48 sgtm Show quoted text On 2014/05/01 21:01:33, mmenke wrote: > On 2014/05/01 19:45:15, mef wrote: > > what about non-android platforms? does it make sense for them to depend on > jni? > > DEPS files aren't per-platform, and aren't used for figuring out what to build. > Instead, they're static checks run on includes. We could do per-file deps, but > I'm not sure we get anything out of it. > > Net does the exact same thing. sgtm
	3

	4 # Limit files that can depend on icu.

	5 "-base/i18n",

	6 "-third_party/icu",

	7 ]

	8

	9 specific_include_rules = {

	10 "url_canon_icu(\.cc\|_unittest\.cc)": [

	11 "+third_party/icu",

	12 ],

	13 }

OLD	NEW