Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2576663004: content::ResourceType clean up (Closed)

Created:
4 years ago by tyoshino (SeeGerritForStatus)
Modified:
4 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, vakh+watch_chromium.org, donnd+watch_chromium.org, jam, Randy Smith (Not in Mondays), chromium-apps-reviews_chromium.org, jfweitz+watch_chromium.org, David Black, Jered, samarth+watch_chromium.org, darin-cc_chromium.org, loading-reviews_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content::ResourceType clean up - Remove unused using statements - Remove unnecessary content:: - Include resource_type.h where IsResourceTypeFrame() is used - Use IsResourceTypeFrame() where we can R=reillyg@chromium.org,mmenke@chromium.org,mattm@chromium.org,treib@chromium.org BUG=none Committed: https://crrev.com/430d2f47056ec2691b43239f6390758a3f2e6ccc Cr-Commit-Position: refs/heads/master@{#438792}

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 28 (18 generated)
tyoshino (SeeGerritForStatus)
4 years ago (2016-12-14 09:03:10 UTC) #8
Marc Treib
iframe_source_unittest.cc lgtm (When adding multiple reviewers, it's considered good form to specify who should look ...
4 years ago (2016-12-14 10:28:50 UTC) #9
tyoshino (SeeGerritForStatus)
On 2016/12/14 10:28:50, Marc Treib wrote: > iframe_source_unittest.cc lgtm > > (When adding multiple reviewers, ...
4 years ago (2016-12-14 15:37:56 UTC) #10
tyoshino (SeeGerritForStatus)
On 2016/12/14 15:37:56, tyoshino(OOODec16-25) wrote: > On 2016/12/14 10:28:50, Marc Treib wrote: > > iframe_source_unittest.cc ...
4 years ago (2016-12-14 15:39:13 UTC) #11
Reilly Grant (use Gerrit)
extensions lgtm
4 years ago (2016-12-14 16:10:52 UTC) #15
mmenke
chrome/browser/loader/, chrome/browser/net, content/browser/loader all LGTM!
4 years ago (2016-12-14 16:34:53 UTC) #16
mattm
safe_browsing_db lgtm
4 years ago (2016-12-14 22:34:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576663004/20001
4 years ago (2016-12-15 08:16:46 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 09:30:31 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-15 09:37:04 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/430d2f47056ec2691b43239f6390758a3f2e6ccc
Cr-Commit-Position: refs/heads/master@{#438792}

Powered by Google App Engine
This is Rietveld 408576698