Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2576643003: Revert of [DevTools] Migrate storage domain to new generator. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate storage domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2572933002/ ) Reason for revert: Manually confirmed that this patch breaks Lighthouse. Original issue's description: > [DevTools] Migrate storage domain to new generator. > > BUG=664683 > TBR=pfeldman > > Committed: https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee > Cr-Commit-Position: refs/heads/master@{#438449} TBR=caseq@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664683 Committed: https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d Cr-Commit-Position: refs/heads/master@{#438538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -39 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/storage_handler.h View 1 chunk +14 lines, -11 lines 0 comments Download
M content/browser/devtools/protocol/storage_handler.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tommycli
Created Revert of [DevTools] Migrate storage domain to new generator.
4 years ago (2016-12-14 17:37:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576643003/1
4 years ago (2016-12-14 17:38:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 17:39:33 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-14 17:41:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d
Cr-Commit-Position: refs/heads/master@{#438538}

Powered by Google App Engine
This is Rietveld 408576698