Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2576613003: Minor, unrelated changes from the browser side mixed-content patch. (Closed)

Created:
4 years ago by carlosk
Modified:
4 years ago
Reviewers:
jam, nasko
CC:
chromium-reviews, msramek+watch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, raymes+watch_chromium.org, darin-cc_chromium.org, markusheintz_
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor, unrelated changes from the browser side mixed-content patch. In the development of patch to move mixed-content checks to the browser (https://crrev.com/1905033002) a few minor changes were made that are unrelated to its core purpose. So I created this change to simplify the original one. They are: - Add missing forward declaration. - Updated a comment referring to an IPC that doesn't exist anymore. - Adds newline. BUG=576270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/617a1b4dfc30bdca2483be73d2f08d5f9b0ca264 Cr-Commit-Position: refs/heads/master@{#438713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
carlosk
jam@: PTAL at chrome/ file. nasko@: PTAL at IPC messages and content/ files. Question: for ...
4 years ago (2016-12-14 03:23:07 UTC) #5
jam
lgtm
4 years ago (2016-12-14 17:48:51 UTC) #10
nasko
LGTM
4 years ago (2016-12-15 01:01:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576613003/1
4 years ago (2016-12-15 01:47:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:52:37 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-15 01:55:43 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/617a1b4dfc30bdca2483be73d2f08d5f9b0ca264
Cr-Commit-Position: refs/heads/master@{#438713}

Powered by Google App Engine
This is Rietveld 408576698