Move enable_pdf to a buildflag header.

Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn.

The assertion for the printing dependency on PDF is moved to the
//printing/BUILD.gn so the enable_pdf flag isn't injected everywhere
enable_printing is needed.

Committed: https://crrev.com/e5cc5c689fef092ac8b0f9bf91caeff492c4e857
Cr-Commit-Position: refs/heads/master@{#438441}

[brettw, 2016-12-13 20:21:25]

Description was changed from

==========
Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn
==========

to

==========
Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn.

The assertion for the printing dependency on PDF is moved to the
//printing/BUILD.gn so the enable_pdf flag isn't injected everywhere
enable_printing is needed.
==========

[brettw, 2016-12-13 20:21:51]

String

[brettw, 2016-12-13 20:21:52]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-12-13 20:22:13]

brettw@chromium.org changed reviewers:
+ raymes@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:22:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:25:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[brettw, 2016-12-13 20:28:57]

Merge

[brettw, 2016-12-13 20:28:57]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 20:29:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:34:03]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-12-13 20:48:12]

Paths

[brettw, 2016-12-13 20:48:13]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 20:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:53:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[brettw, 2016-12-13 21:09:04]

Engine

[brettw, 2016-12-13 21:09:04]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 00:48:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 00:48:49]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-12-14 00:57:16]

lgtm but my gn foo isn't very good at all.

https://codereview.chromium.org/2576573002/diff/80001/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/2576573002/diff/80001/pdf/BUILD.gn#newcode6
pdf/BUILD.gn:6: import("//build/config/chromecast_build.gni")
is this one needed?

[brettw, 2016-12-14 03:39:42]

https://codereview.chromium.org/2576573002/diff/80001/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/2576573002/diff/80001/pdf/BUILD.gn#newcode6
pdf/BUILD.gn:6: import("//build/config/chromecast_build.gni")
On 2016/12/14 00:57:16, raymes wrote:
> is this one needed?

You're right, this was left over from a previous iteration of the patch. Thanks!

[brettw, 2016-12-14 03:39:47]

No Chromecast

[brettw, 2016-12-14 03:39:48]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-12-14 03:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2576573002/#ps100001
(title: "No Chromecast")

[commit-bot: I haz the power, 2016-12-14 03:40:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:27:23]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481686788358050,
"parent_rev": "3fdfcaec4fb104e9026249b4af31011d4def1d93", "commit_rev":
"d5fb6c594348943903e6d48faa912f91d5c5b5cd"}

[commit-bot: I haz the power, 2016-12-14 05:28:04]

Description was changed from

==========
Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn.

The assertion for the printing dependency on PDF is moved to the
//printing/BUILD.gn so the enable_pdf flag isn't injected everywhere
enable_printing is needed.
==========

to

==========
Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn.

The assertion for the printing dependency on PDF is moved to the
//printing/BUILD.gn so the enable_pdf flag isn't injected everywhere
enable_printing is needed.

Review-Url: https://codereview.chromium.org/2576573002
==========

[commit-bot: I haz the power, 2016-12-14 05:28:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-14 05:30:16]

Description was changed from

==========
Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn.

The assertion for the printing dependency on PDF is moved to the
//printing/BUILD.gn so the enable_pdf flag isn't injected everywhere
enable_printing is needed.

Review-Url: https://codereview.chromium.org/2576573002
==========

to

==========
Move enable_pdf to a buildflag header.

Removes the build flag from //build/config and moves it to a new .gni file in
//pdf. Converts the define to a BUILDFLAG.

Makes it possible to unconditionally depend on "//pdf" without checking the
enable_pdf flag. This cleans up most of the callers. There is still a
dependency on plugins and this assertion is moved to the top of
//chrome/common/BUILD.gn.

The assertion for the printing dependency on PDF is moved to the
//printing/BUILD.gn so the enable_pdf flag isn't injected everywhere
enable_printing is needed.

Committed: https://crrev.com/e5cc5c689fef092ac8b0f9bf91caeff492c4e857
Cr-Commit-Position: refs/heads/master@{#438441}
==========

[commit-bot: I haz the power, 2016-12-14 05:30:17]

Patchset 6 (id:??) landed as
https://crrev.com/e5cc5c689fef092ac8b0f9bf91caeff492c4e857
Cr-Commit-Position: refs/heads/master@{#438441}