Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2576543002: [heap] Reland "Use RAIL mode for initial heap sizing" (Closed)

Created:
4 years ago by ulan
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Use RAIL mode for initial heap sizing". The original patch was reverted because of performance regressions caused by removal of old heap sizing heuristics. This patch keeps the old heuristics and adds RAIL mode. BUG=chromium:613518 Review-Url: https://codereview.chromium.org/2576543002 Cr-Commit-Position: refs/heads/master@{#41773} Committed: https://chromium.googlesource.com/v8/v8/+/7bdb906946b94e9ba10de13e104a39bbcabedbd6

Patch Set 1 : original patch #

Patch Set 2 : reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/heap/heap.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
ulan
ptal
4 years ago (2016-12-13 17:54:22 UTC) #4
Hannes Payer (out of office)
lgtm
4 years ago (2016-12-16 16:08:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576543002/40001
4 years ago (2016-12-16 16:09:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576543002/40001
4 years ago (2016-12-16 16:57:51 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 16:59:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/7bdb906946b94e9ba10de13e104a39bbcab...

Powered by Google App Engine
This is Rietveld 408576698