Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2576533003: Converts some services to use aura-mus (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts some services to use aura-mus Specifically autoclick, browser, quick_launch, task_viewer and navigation. This also fixes bug where it was possible client-area wasn't pushed at the right time. BUG=673866 TEST=none R=ben@chromium.org Committed: https://crrev.com/b6f207ca201f3eb08c2150f5c3610c68a30c8984 Cr-Commit-Position: refs/heads/master@{#438402}

Patch Set 1 #

Patch Set 2 : remove log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -114 lines) Patch
M ash/autoclick/mus/autoclick_application.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/autoclick/mus/autoclick_application.cc View 1 6 chunks +21 lines, -27 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 5 chunks +15 lines, -27 lines 0 comments Download
M mash/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M mash/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/browser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/browser/browser.cc View 10 chunks +28 lines, -21 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mash/quick_launch/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mash/quick_launch/quick_launch.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M mash/task_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/navigation/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/public/cpp/view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/navigation/public/cpp/view.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 4 chunks +19 lines, -0 lines 0 comments Download
M ui/views/mus/pointer_watcher_event_router2.cc View 2 chunks +16 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
sky
4 years ago (2016-12-13 21:27:29 UTC) #1
Ben Goodger (Google)
lgtm
4 years ago (2016-12-14 01:57:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576533003/20001
4 years ago (2016-12-14 02:36:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 02:46:09 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-14 02:50:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6f207ca201f3eb08c2150f5c3610c68a30c8984
Cr-Commit-Position: refs/heads/master@{#438402}

Powered by Google App Engine
This is Rietveld 408576698