Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2576523002:
Try removing a MSVC2013 /analyze workaround to see if it is still needed. (Closed)
|
Created:
4 years ago by Nico Modified:
4 years ago Reviewers:
brucedawson CC:
chromium-reviews, vmpstr+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTry removing a MSVC2013 /analyze workaround to see if it is still needed.
Reverts crrev.com/803183004, maybe the problem
was fixed in 2015. (If not, we can revert the revert again.)
BUG=427616
Committed: https://crrev.com/29d59efc930d398c0d878e1b56b404f416dc974a
Cr-Commit-Position: refs/heads/master@{#438270}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + brucedawson@chromium.org
Is there an /analyze trybot? If not, which FYI bot should I watch once this is in?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The /analyze FYI bot is here: https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Windows%20Analyze No trybot. I can't remember how quickly the failures were hit previously but a local build shows no immediate problems with this change, and I do believe that the bug was fixed.
lgtm
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Try removing a MSVC2013 /analyze workaround to see if it is still needed. Reverts https://codereview.chromium.org/803183004/ , maybe the problem was fixed in 2015. (If not, we can revert the revert again.) BUG=427616 ========== to ========== Try removing a MSVC2013 /analyze workaround to see if it is still needed. Reverts crrev.com/803183004, maybe the problem was fixed in 2015. (If not, we can revert the revert again.) BUG=427616 ==========
On 2016/12/13 17:29:10, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... I changed the codereview.chromium.org in the description to crrev.com - that avoids confusion about which link is for the current change. Change back if you disagree. I'm pretty certain this change will work - 11,000 steps completed on my local build.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481650127106080, "parent_rev":
"36ff153e12e3cb94cd5d1b8f09b96e36e9e97e3d", "commit_rev":
"0c47e25913f1ca6cfbbd876220c8cedb9d74f223"}
Message was sent while issue was closed.
Description was changed from ========== Try removing a MSVC2013 /analyze workaround to see if it is still needed. Reverts crrev.com/803183004, maybe the problem was fixed in 2015. (If not, we can revert the revert again.) BUG=427616 ========== to ========== Try removing a MSVC2013 /analyze workaround to see if it is still needed. Reverts crrev.com/803183004, maybe the problem was fixed in 2015. (If not, we can revert the revert again.) BUG=427616 Review-Url: https://codereview.chromium.org/2576523002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Try removing a MSVC2013 /analyze workaround to see if it is still needed. Reverts crrev.com/803183004, maybe the problem was fixed in 2015. (If not, we can revert the revert again.) BUG=427616 Review-Url: https://codereview.chromium.org/2576523002 ========== to ========== Try removing a MSVC2013 /analyze workaround to see if it is still needed. Reverts crrev.com/803183004, maybe the problem was fixed in 2015. (If not, we can revert the revert again.) BUG=427616 Committed: https://crrev.com/29d59efc930d398c0d878e1b56b404f416dc974a Cr-Commit-Position: refs/heads/master@{#438270} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/29d59efc930d398c0d878e1b56b404f416dc974a Cr-Commit-Position: refs/heads/master@{#438270} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
