Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2576503002:
Suppress TSAN race in TimerTest while working on complex fix. (Closed)
DescriptionSuppress TSAN race in TimerTest while working on complex fix.
Fix coming up @ https://codereview.chromium.org/2491613004/ but
suppressing race in mean time to make TSAN bot green again
(issue 672860).
BUG=587199
TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng.
NO_DEPENDENCY_CHECKS=true
Committed: https://crrev.com/243a13726f5baf1a3f5fc9dfa0f4ee651fd87ab4
Cr-Commit-Position: refs/heads/master@{#438749}
Patch Set 1 #Patch Set 2 : rebase #
Dependent Patchsets: Messages
Total messages: 23 (15 generated)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 ========== to ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. ==========
gab@chromium.org changed reviewers: + dcheng@chromium.org
dcheng PTAL, thanks
lgtm
The CQ bit was unchecked by gab@chromium.org
The CQ bit was checked by gab@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2464233002 Patch 1010001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. ========== to ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2576503002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481777418518230,
"parent_rev": "42cfd0fcacc21e7d97dfb08089d122319ea6ae1f", "commit_rev":
"8dcb12efec26305e22c0cf3d81028d6e724062fe"}
Message was sent while issue was closed.
Description was changed from ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. NO_DEPENDENCY_CHECKS=true ========== to ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2576503002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.chromium.org/2576503002 ========== to ========== Suppress TSAN race in TimerTest while working on complex fix. Fix coming up @ https://codereview.chromium.org/2491613004/ but suppressing race in mean time to make TSAN bot green again (issue 672860). BUG=587199 TEST=TimerTest.OneShotTimer_CustomTaskRunner no longer reported as failure by linux_chromium_tsan_rel_ng. NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/243a13726f5baf1a3f5fc9dfa0f4ee651fd87ab4 Cr-Commit-Position: refs/heads/master@{#438749} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/243a13726f5baf1a3f5fc9dfa0f4ee651fd87ab4 Cr-Commit-Position: refs/heads/master@{#438749} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
