Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2576463002: [Autoplay] Add histogram metrics for cross-origin autoplay muted experiment (Closed)

Created:
4 years ago by Zhiqiang Zhang (Slow)
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autoplay] Add histogram metrics for cross-origin autoplay muted experiment We have already landed rappor metrics for cross-origin autoplay muted experiment, we should land corresponding histogram metrics as well. BUG=672526 Committed: https://crrev.com/6f5262dd77fa3e767d9179123ac774dbf0d4d9ac Cr-Commit-Position: refs/heads/master@{#438222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -22 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 6 chunks +26 lines, -16 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Zhiqiang Zhang (Slow)
4 years ago (2016-12-13 14:15:58 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years ago (2016-12-13 14:22:16 UTC) #4
Zhiqiang Zhang (Slow)
+rkaplow: histograms.xml
4 years ago (2016-12-13 14:35:19 UTC) #6
rkaplow
lgtm
4 years ago (2016-12-13 15:51:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576463002/1
4 years ago (2016-12-13 15:56:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 18:05:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-13 18:08:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f5262dd77fa3e767d9179123ac774dbf0d4d9ac
Cr-Commit-Position: refs/heads/master@{#438222}

Powered by Google App Engine
This is Rietveld 408576698