[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misuse

[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misuse

BUG=chromium:468240
Review-Url: https://codereview.chromium.org/2576453002
Cr-Commit-Position: refs/heads/master@{#41837}
Committed: https://chromium.googlesource.com/v8/v8/+/17318bbd393f8e1b60a00d1cb1fb57befdec0874

[Michael Lippautz, 2016-12-13 16:09:33]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:09:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 16:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 16:37:56]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-12-19 16:42:40]

Description was changed from

==========
[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misue

BUG=
==========

to

==========
[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misue

BUG=chromium:468240
==========

[Michael Lippautz, 2016-12-19 16:42:40]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2016-12-19 16:42:52]

ptal

[Michael Lippautz, 2016-12-19 16:43:07]

Description was changed from

==========
[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misue

BUG=chromium:468240
==========

to

==========
[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misuse

BUG=chromium:468240
==========

[Hannes Payer (out of office), 2016-12-19 16:50:05]

lgtm

https://codereview.chromium.org/2576453002/diff/80001/src/heap/embedder-traci...
File src/heap/embedder-tracing.h (right):

https://codereview.chromium.org/2576453002/diff/80001/src/heap/embedder-traci...
src/heap/embedder-tracing.h:48: WrapperCache cached_wrappers_to_trace_;
How about wrappers_to_trace_? It's simpler.

[Michael Lippautz, 2016-12-19 16:53:08]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 16:53:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 16:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 16:54:45]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18146)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18052)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30968)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/19712)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19790)

[Michael Lippautz, 2016-12-19 17:00:54]

Patchset #6 (id:100001) has been deleted

[Michael Lippautz, 2016-12-19 17:01:24]

https://codereview.chromium.org/2576453002/diff/80001/src/heap/embedder-traci...
File src/heap/embedder-tracing.h (right):

https://codereview.chromium.org/2576453002/diff/80001/src/heap/embedder-traci...
src/heap/embedder-tracing.h:48: WrapperCache cached_wrappers_to_trace_;
On 2016/12/19 16:50:05, Hannes Payer wrote:
> How about wrappers_to_trace_? It's simpler.

I want to indicate that this is just the cached v8 part of the wrappers, so I am
leaving this as is.

[Michael Lippautz, 2016-12-19 17:01:28]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:01:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 17:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 17:10:31]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Lippautz, 2016-12-19 18:39:14]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 18:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:43:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18098)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14501)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/19802)

[Michael Lippautz, 2016-12-20 08:51:36]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 08:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 09:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 09:22:00]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-12-20 09:31:57]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-12-20 09:31:57]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2576453002/#ps160001
(title: "Include")

[commit-bot: I haz the power, 2016-12-20 09:32:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 09:35:06]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1482226317149620,
"parent_rev": "7e8bd39a4993590eee5fdfe5936b22a2cc2621db", "commit_rev":
"17318bbd393f8e1b60a00d1cb1fb57befdec0874"}

[commit-bot: I haz the power, 2016-12-20 09:35:10]

Description was changed from

==========
[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misuse

BUG=chromium:468240
==========

to

==========
[heap] Create a thin wrapper around wrapper tracing in V8 to avoid misuse

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2576453002
Cr-Commit-Position: refs/heads/master@{#41837}
Committed:
https://chromium.googlesource.com/v8/v8/+/17318bbd393f8e1b60a00d1cb1fb57befde...
==========

[commit-bot: I haz the power, 2016-12-20 09:35:11]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/17318bbd393f8e1b60a00d1cb1fb57befde...