Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2576423002: Revert of Revert "Disable local background equivalence when we have a box shadow due to painting bug (Closed)

Created:
4 years ago by smcgruer
Modified:
4 years ago
Reviewers:
schenney, chrishtr, Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Disable local background equivalence when we have a box shadow due to painting bug." (patchset #5 id:80001 of https://codereview.chromium.org/2561183002/ ) Reason for revert: Caused a regression in drawing backgrounds when the window was sized around 1280x1024. Regression seen in at least Windows and Linux - see http://crbug.com/674429 BUG=674429 Original issue's description: > Revert "Disable local background equivalence when we have a box shadow due to painting bug." > > This reverts commit a12e7a002f85301bf013b45e6e8bb61455304a76. > > BUG=646464 > > TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have > box shadows and the first box has sub-pixel AA text > > Committed: https://crrev.com/c765a85995920f79d3132e06a2c146316b823c3f > Cr-Commit-Position: refs/heads/master@{#438020} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646464 Committed: https://crrev.com/4baddb7eb1745ba1f39697e89e303805f90efe16 Cr-Commit-Position: refs/heads/master@{#438897}

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
smcgruer
Created Revert of Revert "Disable local background equivalence when we have a box shadow due ...
4 years ago (2016-12-15 15:51:32 UTC) #1
smcgruer
As per http://crbug.com/674429, if anyone wants to try and fix the paint bug instead feel ...
4 years ago (2016-12-15 15:55:25 UTC) #4
Xianzhu
lgtm
4 years ago (2016-12-15 16:25:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576423002/1
4 years ago (2016-12-15 19:44:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 19:49:07 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 19:52:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4baddb7eb1745ba1f39697e89e303805f90efe16
Cr-Commit-Position: refs/heads/master@{#438897}

Powered by Google App Engine
This is Rietveld 408576698