chrome: Include headless resources

chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904
Committed: https://crrev.com/c05be0bcf4d2e0c75e64e0fa244bf40907aa2095
Cr-Commit-Position: refs/heads/master@{#439112}

[Sami, 2016-12-15 14:54:06]

Description was changed from

==========
chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904
==========

to

==========
chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904
==========

[Sami, 2016-12-15 14:54:06]

skyostil@chromium.org changed reviewers:
+ altimin@chromium.org, jochen@chromium.org

[Sami, 2016-12-15 14:54:15]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:54:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-12-15 14:55:01]

Adding reviewers:

altimin@: headless/
jochen@: chrome/

Thanks!

[commit-bot: I haz the power, 2016-12-15 14:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:57:55]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sami, 2016-12-15 14:58:52]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:59:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 15:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:02:25]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[jochen (gone - plz use gerrit), 2016-12-15 15:22:58]

lgtm

[Sami, 2016-12-15 15:30:59]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 15:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 16:40:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 16:40:25]

Dry run: This issue passed the CQ dry run.

[altimin, 2016-12-15 18:43:23]

https://codereview.chromium.org/2576413002/diff/40001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.cc (right):

https://codereview.chromium.org/2576413002/diff/40001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.cc:123:
ui::ResourceBundle::InitSharedInstanceWithPakPath(pak_file);
AFAIK, InitSharedInstanceWithPakPath is debug-only. InitSharedInstanceWithLocale
is the way to go, IIRC.

[Sami, 2016-12-15 18:44:30]

https://codereview.chromium.org/2576413002/diff/40001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.cc (right):

https://codereview.chromium.org/2576413002/diff/40001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.cc:123:
ui::ResourceBundle::InitSharedInstanceWithPakPath(pak_file);
On 2016/12/15 18:43:23, altimin wrote:
> AFAIK, InitSharedInstanceWithPakPath is debug-only.
InitSharedInstanceWithLocale
> is the way to go, IIRC.

That's right. Do you mind if I do that as a follow-up since we're already using
the *WithPak() variant?

[altimin, 2016-12-15 18:47:25]

lgtm

[Sami, 2016-12-15 18:49:36]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-12-15 18:49:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2576413002/#ps60001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-12-15 18:50:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 20:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 20:26:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2016-12-16 00:10:12]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:11:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 06:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 06:03:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2016-12-16 14:36:53]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-12-16 14:37:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 15:36:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481899013245350,
"parent_rev": "7d2074e5780fc2288e032d35fbf3be921c945d9c", "commit_rev":
"b6d7642ab0db23bf3e75eae98f0b5461263e0539"}

[commit-bot: I haz the power, 2016-12-16 15:36:45]

Description was changed from

==========
chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904
==========

to

==========
chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904

Review-Url: https://codereview.chromium.org/2576413002
==========

[commit-bot: I haz the power, 2016-12-16 15:36:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-16 15:40:12]

Description was changed from

==========
chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904

Review-Url: https://codereview.chromium.org/2576413002
==========

to

==========
chrome: Include headless resources

To support the --headless flag, include resources needed by the headless
library in Chrome's resources.pak. The size of these resources is about
1.7 KiB.

This patch also makes the headless
library fall back to loading resources.pak if headless_lib.pak isn't
found. The reason is that the former is shipped with Chrome while the
latter is used in purely headless builds.

BUG=612904

Committed: https://crrev.com/c05be0bcf4d2e0c75e64e0fa244bf40907aa2095
Cr-Commit-Position: refs/heads/master@{#439112}
==========

[commit-bot: I haz the power, 2016-12-16 15:40:13]

Patchset 4 (id:??) landed as
https://crrev.com/c05be0bcf4d2e0c75e64e0fa244bf40907aa2095
Cr-Commit-Position: refs/heads/master@{#439112}