Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2576373002: Fix HTML parser CDATA edge-case and sync state names with spec (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix HTML parser CDATA edge-case and sync state names with spec When encountering a sequence of ']]]' at the end of a CDATA section, we should only buffer one ']' (the first one) and "remember" the other two. The states exists in the spec[1][2][3] nowadays, so sync the names and remove the comment about the states not being in the spec. Fixes two subtests of wpt/html/syntax/parsing/html5lib_tests21.html. [1] https://html.spec.whatwg.org/multipage/syntax.html#cdata-section-state [2] https://html.spec.whatwg.org/multipage/syntax.html#cdata-section-bracket-state [3] https://html.spec.whatwg.org/multipage/syntax.html#cdata-section-end-state BUG=674496 Committed: https://crrev.com/e02441191c08939fd05e7a5fdf619b68e91558a2 Cr-Commit-Position: refs/heads/master@{#439396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -35 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/html/syntax/parsing/html5lib_tests21-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fs
4 years ago (2016-12-15 12:16:51 UTC) #8
kouhei (in TOK)
lgtm I really appreciate this change! Thanks!
4 years ago (2016-12-19 00:50:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576373002/1
4 years ago (2016-12-19 00:50:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 03:11:52 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-19 03:14:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e02441191c08939fd05e7a5fdf619b68e91558a2
Cr-Commit-Position: refs/heads/master@{#439396}

Powered by Google App Engine
This is Rietveld 408576698