Make AppWindowWaiter a common test support

Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.

Committed: https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554
Cr-Commit-Position: refs/heads/master@{#439406}

[Qiang(Joe) Xu, 2016-12-15 07:46:57]

Description was changed from

==========
Make AppWindowWaiter a common test support

BUG=672312
TEST=automated tests.
==========

to

==========
Make AppWindowWaiter a common test support

BUG=672312
TEST=automated tests.
==========

[Qiang(Joe) Xu, 2016-12-15 07:46:57]

warx@chromium.org changed reviewers:
+ benwells@chromium.org

[Qiang(Joe) Xu, 2016-12-15 07:48:09]

warx@chromium.org changed reviewers:
+ sky@chromium.org

[Qiang(Joe) Xu, 2016-12-15 07:48:25]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 07:48:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 08:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 08:53:19]

Dry run: This issue passed the CQ dry run.

[Qiang(Joe) Xu, 2016-12-15 09:15:41]

Description was changed from

==========
Make AppWindowWaiter a common test support

BUG=672312
TEST=automated tests.
==========

to

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to extensions namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.
==========

[Qiang(Joe) Xu, 2016-12-15 09:16:41]

benwells@ for extensions/, sky@ for chrome/

Thanks!

[sky, 2016-12-15 16:44:37]

chrome LGTM

[benwells, 2016-12-16 00:34:30]

Is it possible to move it into apps/ instead?

[Qiang(Joe) Xu, 2016-12-16 05:52:56]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 05:53:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2016-12-16 06:45:50]

Description was changed from

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to extensions namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.
==========

to

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.
==========

[Qiang(Joe) Xu, 2016-12-16 06:46:10]

Changes: move from extensions/ to apps/

Thanks!

[commit-bot: I haz the power, 2016-12-16 07:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 07:48:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2016-12-18 23:14:50]

lgtm with a small nit

https://codereview.chromium.org/2576353002/diff/20001/apps/test/app_window_wa...
File apps/test/app_window_waiter.h (right):

https://codereview.chromium.org/2576353002/diff/20001/apps/test/app_window_wa...
apps/test/app_window_waiter.h:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
Nit: just leave the copyright as this isn't a new file, it's just a move. Same
for next file.

[Qiang(Joe) Xu, 2016-12-19 01:47:55]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2016-12-19 01:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2576353002/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-12-19 01:48:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 04:18:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482112075372760,
"parent_rev": "86a44419a3f37a27d5f22242125d8926b427d258", "commit_rev":
"02feb9d3acdfab742b4de019f7cc949abc317914"}

[commit-bot: I haz the power, 2016-12-19 04:19:18]

Description was changed from

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.
==========

to

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.

Review-Url: https://codereview.chromium.org/2576353002
==========

[commit-bot: I haz the power, 2016-12-19 04:19:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-19 04:21:27]

Description was changed from

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.

Review-Url: https://codereview.chromium.org/2576353002
==========

to

==========
Make AppWindowWaiter a common test support

Changes:
(1) move AppWindowWaiter from chromeos namespace to apps namespace
(2) apply the new test support

BUG=672312
TEST=automated tests.

Committed: https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554
Cr-Commit-Position: refs/heads/master@{#439406}
==========

[commit-bot: I haz the power, 2016-12-19 04:21:28]

Patchset 3 (id:??) landed as
https://crrev.com/dcac6d9f136c6f0d92a65bdf03f3e2e6f7aa7554
Cr-Commit-Position: refs/heads/master@{#439406}