Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2576303002: DevTools: Refactor Timeline Landing Page (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
paulirish, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Refactor Timeline Landing Page Make two presets: Basic and Advanced Make two buttons: Record and Record Page Load BUG=570441 Committed: https://crrev.com/a335187e748bfdc9ef0b4a5c961c3633f6e867de Cr-Commit-Position: refs/heads/master@{#438956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -56 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js View 4 chunks +37 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/timelineLandingPage.css View 2 chunks +5 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorViewTabbedPane.css View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/tabbedPane.css View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
alph
4 years ago (2016-12-15 03:18:19 UTC) #2
pfeldman
lgtm
4 years ago (2016-12-15 18:59:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576303002/1
4 years ago (2016-12-15 19:03:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357250)
4 years ago (2016-12-15 21:26:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576303002/1
4 years ago (2016-12-15 22:14:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 23:47:19 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 23:49:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a335187e748bfdc9ef0b4a5c961c3633f6e867de
Cr-Commit-Position: refs/heads/master@{#438956}

Powered by Google App Engine
This is Rietveld 408576698