Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 2576283005: Add regression tests for https://crbug.com/606990. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add regression tests for https://crbug.com/606990. It seems like https://crbug.com/606990 is fixed, this CL adds regression tests for it. BUG=606990 Committed: https://crrev.com/1ff808709f5e371c20c7238c429db5f2c23e6d95 Cr-Commit-Position: refs/heads/master@{#439187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Bence
Ryan: PTAL. Thank you.
4 years ago (2016-12-16 20:03:04 UTC) #6
Ryan Hamilton
lgtm
4 years ago (2016-12-16 20:06:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576283005/1
4 years ago (2016-12-16 20:07:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 20:58:35 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 21:03:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ff808709f5e371c20c7238c429db5f2c23e6d95
Cr-Commit-Position: refs/heads/master@{#439187}

Powered by Google App Engine
This is Rietveld 408576698