[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

Each BLE device has a limited number of BLE advertisement slots; this class queues devices to which to advertise and provides functionality for moving devices to the end of the queue and requesting the devices which should be advertised.

BUG=672263
Committed: https://crrev.com/8e44546b8e145f87efe6806573b8ffb3c10b61da
Cr-Commit-Position: refs/heads/master@{#439570}

[Kyle Horimoto, 2016-12-15 01:51:12]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org

[Ryan Hansberry, 2016-12-19 20:06:52]

lgtm

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/ble_advertisement_device_queue.h (right):

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue.h:40: bool
SetDevices(std::vector<cryptauth::RemoteDevice> devices);
Explain what a return value of true or false means.

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
(right):

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue_unittest.cc:150:
EXPECT_THAT(to_advertise, ElementsAre(all_devices[1], all_devices[2]));
nit: Is there an expected consistency to having expected value vs. test values
as left/right arguments? For instance, your EXPECT_EQ(static_cast<size_t>(4),
device_queue_->GetSize()); call has the expected value as the left-side arg, but
here the expected value is on the right.

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue_unittest.cc:166:
EXPECT_FALSE(device_queue_->SetDevices(devices));
Any reason to have this call twice?

[Kyle Horimoto, 2016-12-19 20:15:03]

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/ble_advertisement_device_queue.h (right):

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue.h:40: bool
SetDevices(std::vector<cryptauth::RemoteDevice> devices);
On 2016/12/19 20:06:52, Ryan Hansberry wrote:
> Explain what a return value of true or false means.

Done.

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
(right):

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2016/12/19 20:06:52, Ryan Hansberry wrote:
> 2016

Done.

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue_unittest.cc:150:
EXPECT_THAT(to_advertise, ElementsAre(all_devices[1], all_devices[2]));
On 2016/12/19 20:06:52, Ryan Hansberry wrote:
> nit: Is there an expected consistency to having expected value vs. test values
> as left/right arguments? For instance, your EXPECT_EQ(static_cast<size_t>(4),
> device_queue_->GetSize()); call has the expected value as the left-side arg,
but
> here the expected value is on the right.

The EXPECT_EQ() always takes expected first and actual second.

EXPECT_THAT() takes the test array and allows you to pass other matchers, such
as ElementsAre(). This is the correct way to test this.

https://codereview.chromium.org/2576283002/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_advertisement_device_queue_unittest.cc:166:
EXPECT_FALSE(device_queue_->SetDevices(devices));
On 2016/12/19 20:06:52, Ryan Hansberry wrote:
> Any reason to have this call twice?

Yes, this test is meant to test setting the same devices multiple times.

[Kyle Horimoto, 2016-12-19 20:15:37]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2016-12-19 20:15:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
hansberry@chromium.org
Link to the patchset: https://codereview.chromium.org/2576283002/#ps20001
(title: "hansberry@ comments.")

[commit-bot: I haz the power, 2016-12-19 20:16:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:28:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482178537984450,
"parent_rev": "1b0cd747cfc2daad3b69a806378fb7e8c8b90952", "commit_rev":
"85b67318048164718e6c0cb4fa670e61b2bbed0c"}

[commit-bot: I haz the power, 2016-12-19 21:29:17]

Description was changed from

==========
[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

Each BLE device has a limited number of BLE advertisement slots; this class
queues devices to which to advertise and provides functionality for moving
devices to the end of the queue and requesting the devices which should be
advertised.

BUG=672263
==========

to

==========
[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

Each BLE device has a limited number of BLE advertisement slots; this class
queues devices to which to advertise and provides functionality for moving
devices to the end of the queue and requesting the devices which should be
advertised.

BUG=672263

Review-Url: https://codereview.chromium.org/2576283002
==========

[commit-bot: I haz the power, 2016-12-19 21:29:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-19 21:33:19]

Description was changed from

==========
[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

Each BLE device has a limited number of BLE advertisement slots; this class
queues devices to which to advertise and provides functionality for moving
devices to the end of the queue and requesting the devices which should be
advertised.

BUG=672263

Review-Url: https://codereview.chromium.org/2576283002
==========

to

==========
[Chrome OS Tether] Create BleAdvertisementDeviceQueue.

Each BLE device has a limited number of BLE advertisement slots; this class
queues devices to which to advertise and provides functionality for moving
devices to the end of the queue and requesting the devices which should be
advertised.

BUG=672263

Committed: https://crrev.com/8e44546b8e145f87efe6806573b8ffb3c10b61da
Cr-Commit-Position: refs/heads/master@{#439570}
==========

[commit-bot: I haz the power, 2016-12-19 21:33:20]

Patchset 2 (id:??) landed as
https://crrev.com/8e44546b8e145f87efe6806573b8ffb3c10b61da
Cr-Commit-Position: refs/heads/master@{#439570}