Issue 2576273002: Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without CHROMIUM_framebuffer_multisample

Issue 2576273002: Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without CHROMIUM_framebuffer_multisample (Closed)

Created:
4 years ago by Kai Ninomiya

Modified:
4 years ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews, piman+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without CHROMIUM_framebuffer_multisample Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on Qualcomm), this allows glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer without throwing GL_INVALID_ENUM. BUG=674357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/99c05525dbe876d59c7997c4821d1f4c4092c548 Cr-Commit-Position: refs/heads/master@{#438881}

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	gpu/command_buffer/client/gles2_implementation.cc	View		2 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 21 (16 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kai Ninomiya

Description was changed from ========== Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 on Qualcomm Even if GL_CHROMIUM_framebuffer_multisample ...

4 years ago (2016-12-15 01:14:45 UTC) #1

Description was changed from

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 on Qualcomm

Even if GL_CHROMIUM_framebuffer_multisample isn't available, this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
==========

to

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 on Qualcomm

Even if GL_CHROMIUM_framebuffer_multisample isn't available, this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Kai Ninomiya

Description was changed from ========== Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 on Qualcomm Even if GL_CHROMIUM_framebuffer_multisample ...

4 years ago (2016-12-15 01:15:38 UTC) #2

Description was changed from

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 on Qualcomm

Even if GL_CHROMIUM_framebuffer_multisample isn't available, this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Kai Ninomiya

kainino@chromium.org changed reviewers: + zmo@chromium.org

4 years ago (2016-12-15 01:15:38 UTC) #3

kainino@chromium.org changed reviewers:
+ zmo@chromium.org

Kai Ninomiya

Description was changed from ========== Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without CHROMIUM_framebuffer_multisample Even if GL_CHROMIUM_framebuffer_multisample ...

4 years ago (2016-12-15 01:15:56 UTC) #4

Description was changed from

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Kai Ninomiya

zmo, PTAL

4 years ago (2016-12-15 01:16:04 UTC) #5

zmo, PTAL

Kai Ninomiya

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

4 years ago (2016-12-15 01:19:36 UTC) #6

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576273002/1

4 years ago (2016-12-15 01:19:57 UTC) #7

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years ago (2016-12-15 01:27:49 UTC) #8

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/315190)

4 years ago (2016-12-15 01:27:50 UTC) #9

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Kai Ninomiya

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

4 years ago (2016-12-15 03:11:53 UTC) #10

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576273002/1

4 years ago (2016-12-15 03:12:16 UTC) #11

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years ago (2016-12-15 04:06:15 UTC) #12

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years ago (2016-12-15 04:06:15 UTC) #13

Dry run: This issue passed the CQ dry run.

Zhenyao Mo

LGTM

4 years ago (2016-12-15 18:38:08 UTC) #14

LGTM

Kai Ninomiya

The CQ bit was checked by kainino@chromium.org

4 years ago (2016-12-15 18:44:16 UTC) #15

The CQ bit was checked by kainino@chromium.org

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576273002/1

4 years ago (2016-12-15 18:44:34 UTC) #16

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481827456812150, "parent_rev": "0271c03a4bc2889d9056eca8ed3eb2126e845cbe", "commit_rev": "d8cadf92a9bd8757f2e6ff65545a0810bb8da394"}

4 years ago (2016-12-15 18:48:08 UTC) #17

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481827456812150, "parent_rev":
"0271c03a4bc2889d9056eca8ed3eb2126e845cbe", "commit_rev":
"d8cadf92a9bd8757f2e6ff65545a0810bb8da394"}

commit-bot: I haz the power

Description was changed from ========== Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without CHROMIUM_framebuffer_multisample Even if GL_CHROMIUM_framebuffer_multisample ...

4 years ago (2016-12-15 18:48:33 UTC) #18

Message was sent while issue was closed.

Description was changed from

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2576273002
==========

commit-bot: I haz the power

Committed patchset #1 (id:1)

4 years ago (2016-12-15 18:48:34 UTC) #19

Message was sent while issue was closed.

Committed patchset #1 (id:1)

commit-bot: I haz the power

Description was changed from ========== Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without CHROMIUM_framebuffer_multisample Even if GL_CHROMIUM_framebuffer_multisample ...

4 years ago (2016-12-15 18:50:35 UTC) #20

Message was sent while issue was closed.

Description was changed from

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2576273002
==========

to

==========
Allow GL_{DRAW,READ}_FRAMEBUFFER on OpenGL ES3 without
CHROMIUM_framebuffer_multisample

Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on
Qualcomm), this allows
glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer
without throwing GL_INVALID_ENUM.

BUG=674357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/99c05525dbe876d59c7997c4821d1f4c4092c548
Cr-Commit-Position: refs/heads/master@{#438881}
==========

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/99c05525dbe876d59c7997c4821d1f4c4092c548 Cr-Commit-Position: refs/heads/master@{#438881}

4 years ago (2016-12-15 18:50:36 UTC) #21

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/99c05525dbe876d59c7997c4821d1f4c4092c548
Cr-Commit-Position: refs/heads/master@{#438881}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages