Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2576253002:
ES6 Style: add presubmit prompt about => in code that might run on iOS9 (Closed)
|
Created:
4 years ago by Dan Beam Modified:
4 years ago Reviewers:
Dirk Pranke CC:
chromium-reviews, groby-ooo-7-16 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionES6 Style: add presubmit prompt about => in code that might run on iOS9
An action item from this ES6 proposal:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU
R=dpranke@chromium.org
BUG=671426
Committed: https://crrev.com/1ec68ac2a381d7f3effdfa43f44cd62578881da3
Cr-Commit-Position: refs/heads/master@{#438754}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 R=groby@chromium.org BUG=671426 ========== to ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 R=groby@chromium.org BUG=671426 ==========
dbeam@chromium.org changed reviewers: + dpranke@chromium.org - groby@chromium.org
Description was changed from ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 R=groby@chromium.org BUG=671426 ========== to ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=groby@chromium.org BUG=671426 ==========
Description was changed from ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=groby@chromium.org BUG=671426 ========== to ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=dpranke@chromium.org BUG=671426 ==========
this seems like a good idea whether => is allowed or not
lgtm, hpoefully we won't hit false positives in comments. Did you run a grep to find out?
On 2016/12/15 02:17:06, Dirk Pranke wrote: > lgtm, hpoefully we won't hit false positives in comments. Did you run a grep to > find out? yes, and the only place that came up was: components/test/data/ autofill/automated_integration/action_recorder_extension/ password_manager/form_annotation_extension/background.js which probably aren't changed much. I could blacklist these, but don't know that it matters much (happy to do so if folks hit problems).
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ok, sounds good.
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481779111545330, "parent_rev":
"9dc6b7b70c1b39592b2607a8c7ffa232cee7e18b", "commit_rev":
"9b47877e71960669d4f76db52b67b6ea78a67790"}
Message was sent while issue was closed.
Description was changed from ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=dpranke@chromium.org BUG=671426 ========== to ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=dpranke@chromium.org BUG=671426 Review-Url: https://codereview.chromium.org/2576253002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=dpranke@chromium.org BUG=671426 Review-Url: https://codereview.chromium.org/2576253002 ========== to ========== ES6 Style: add presubmit prompt about => in code that might run on iOS9 An action item from this ES6 proposal: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iJrC4PVSfoU R=dpranke@chromium.org BUG=671426 Committed: https://crrev.com/1ec68ac2a381d7f3effdfa43f44cd62578881da3 Cr-Commit-Position: refs/heads/master@{#438754} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1ec68ac2a381d7f3effdfa43f44cd62578881da3 Cr-Commit-Position: refs/heads/master@{#438754} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
