Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2576243003: Add an experiment to redirect DOMStorageTaskRunner to TaskScheduler. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an experiment to redirect DOMStorageTaskRunner to TaskScheduler. Using a bug as an opportunity to experiment with TaskScheduler (as well as confirm the issue is what we think it is: a priority inversion where a sync IPC from the renderer is blocking on a response from the BlockingPool). Only logical difference is that TaskScheduler doesn't have a notion of named sequences and as such every DOMStorageContextWrapper will have its own primary and commit sequence instead of sharing one with other DOMStorageContextWrapper. If anything that's a good thing as it allows multiple profiles to do their DOMStorage ops in parallel? Don't think this can conflict..? BUG=665588, 622400 Committed: https://crrev.com/72b1a059ae930ebe1dda804e607f251d3ae94a70 Cr-Commit-Position: refs/heads/master@{#439575}

Patch Set 1 #

Patch Set 2 : typo in comment #

Patch Set 3 : rebase on r438937 #

Patch Set 4 : update dependencies #

Patch Set 5 : rebase on r439147 #

Patch Set 6 : update dependencies #

Patch Set 7 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -81 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 3 chunks +33 lines, -6 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.h View 4 chunks +14 lines, -24 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.cc View 3 chunks +18 lines, -46 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 43 (33 generated)
gab
@michaeln PTAL, thanks!
4 years ago (2016-12-15 22:27:53 UTC) #3
gab
On 2016/12/15 22:27:53, gab wrote: > @michaeln PTAL, thanks! @nick for content_browser_client.* addition
4 years ago (2016-12-15 22:34:43 UTC) #9
ncarter (slow)
lgtm
4 years ago (2016-12-15 23:18:02 UTC) #14
michaeln
lgtm 2 > If anything that's a good agreed
4 years ago (2016-12-15 23:57:09 UTC) #15
commit-bot: I haz the power
This CL has an open dependency (Issue 2574403002 Patch 20001). Please resolve the dependency and ...
4 years ago (2016-12-16 00:22:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576243003/40001
4 years ago (2016-12-16 13:25:25 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/358007)
4 years ago (2016-12-16 14:24:52 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576243003/120001
4 years ago (2016-12-19 20:24:05 UTC) #38
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years ago (2016-12-19 21:41:19 UTC) #41
commit-bot: I haz the power
4 years ago (2016-12-19 21:44:22 UTC) #43
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/72b1a059ae930ebe1dda804e607f251d3ae94a70
Cr-Commit-Position: refs/heads/master@{#439575}

Powered by Google App Engine
This is Rietveld 408576698