Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2576243002: DevTools: keep the stick to bottom behavior and update scroll bar position while iterating console … (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
einbinder, dgozman, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: keep the stick to bottom behavior and update scroll bar position while iterating console history. BUG=667072 Committed: https://crrev.com/0342d5e0c9cec8cc41db3c5b6fa50467ba978cfe Cr-Commit-Position: refs/heads/master@{#438907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pfeldman
4 years ago (2016-12-15 00:07:14 UTC) #2
dgozman
lgtm
4 years ago (2016-12-15 02:28:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576243002/1
4 years ago (2016-12-15 02:29:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/139183)
4 years ago (2016-12-15 02:35:25 UTC) #7
luoe
This fixes the bug in the description. For reference, there is still another bug that ...
4 years ago (2016-12-15 03:04:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576243002/1
4 years ago (2016-12-15 18:55:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 20:15:58 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 20:18:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0342d5e0c9cec8cc41db3c5b6fa50467ba978cfe
Cr-Commit-Position: refs/heads/master@{#438907}

Powered by Google App Engine
This is Rietveld 408576698