Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2576233005: Remove some unused resources. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
oshima, Dan Beam
CC:
chromium-reviews, tfarina, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused resources. And move one to the one webui surface it's used for. BUG=522168 TBR=oshima@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e0e93b092fc1f2dbb9120567512cf4d3642cbbd9 Cr-Commit-Position: refs/heads/master@{#439104}

Patch Set 1 #

Total comments: 3

Patch Set 2 : flatten #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
D chrome/app/theme/default_100_percent/common/autofill_dialog_menu_button_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/autofill_dialog_menu_button_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/autofill_dialog_menu_button_normal.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/autofill_dialog_menu_button_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/browser_action_normal.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/chevron_left.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/autofill_dialog_menu_button_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/autofill_dialog_menu_button_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/autofill_dialog_menu_button_normal.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/autofill_dialog_menu_button_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/browser_action_normal.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/chevron_left.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 1 chunk +1 line, -3 lines 0 comments Download
A + chrome/browser/resources/local_discovery/chevron_left-1x.png View Binary file 0 comments Download
A + chrome/browser/resources/local_discovery/chevron_left-2x.png View Binary file 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.css View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Evan Stade
Dan, can you look at chrome/browser/resources/? The rest of the CL is TBR.
4 years ago (2016-12-16 01:43:36 UTC) #4
Dan Beam
https://codereview.chromium.org/2576233005/diff/1/chrome/browser/resources/local_discovery/local_discovery.css File chrome/browser/resources/local_discovery/local_discovery.css (right): https://codereview.chromium.org/2576233005/diff/1/chrome/browser/resources/local_discovery/local_discovery.css#newcode120 chrome/browser/resources/local_discovery/local_discovery.css:120: url(chevron_left-2x.png) 2x) i think you need a flattenhtml="true" in ...
4 years ago (2016-12-16 01:55:56 UTC) #8
Evan Stade
https://codereview.chromium.org/2576233005/diff/1/chrome/browser/resources/local_discovery/local_discovery.css File chrome/browser/resources/local_discovery/local_discovery.css (right): https://codereview.chromium.org/2576233005/diff/1/chrome/browser/resources/local_discovery/local_discovery.css#newcode120 chrome/browser/resources/local_discovery/local_discovery.css:120: url(chevron_left-2x.png) 2x) On 2016/12/16 01:55:56, Dan Beam wrote: > ...
4 years ago (2016-12-16 02:00:19 UTC) #9
Dan Beam
~ magic ~, that's how https://codereview.chromium.org/2576233005/diff/1/chrome/browser/resources/local_discovery/local_discovery.css File chrome/browser/resources/local_discovery/local_discovery.css (right): https://codereview.chromium.org/2576233005/diff/1/chrome/browser/resources/local_discovery/local_discovery.css#newcode120 chrome/browser/resources/local_discovery/local_discovery.css:120: url(chevron_left-2x.png) 2x) On 2016/12/16 ...
4 years ago (2016-12-16 02:02:25 UTC) #10
Evan Stade
thanks, updated. (The magic loses some of its charm when you know how it works.)
4 years ago (2016-12-16 02:12:49 UTC) #11
Dan Beam
lgtm
4 years ago (2016-12-16 05:28:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576233005/20001
4 years ago (2016-12-16 14:53:04 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 14:57:25 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-16 14:59:54 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0e93b092fc1f2dbb9120567512cf4d3642cbbd9
Cr-Commit-Position: refs/heads/master@{#439104}

Powered by Google App Engine
This is Rietveld 408576698