Consolidating the mojo NativeRunner functionality.

Consolidating the functionality offered by NativeRunner by merging the NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.

BUG=674311
Committed: https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7
Cr-Commit-Position: refs/heads/master@{#439256}

[Jay Civelli, 2016-12-14 23:57:44]

Description was changed from

==========
Consolidated the mojo NativeRunner class.

Simplifying the NativeRunner into a single ServiceProcessLauncher class.

BUG=674311
==========

to

==========
Consolidating the functionality offered by NativeRunner by merging NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost into a new into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.


BUG=674311
==========

[Jay Civelli, 2016-12-14 23:57:44]

jcivelli@chromium.org changed reviewers:
+ rockot@chromium.org

[Jay Civelli, 2016-12-14 23:58:32]

Description was changed from

==========
Consolidating the functionality offered by NativeRunner by merging NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost into a new into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.


BUG=674311
==========

to

==========
Consolidating the functionality offered by NativeRunner by merging the
NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.


BUG=674311
==========

[Jay Civelli, 2016-12-14 23:58:46]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:59:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:04:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:04:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-12-15 01:13:45]

lgtm

https://codereview.chromium.org/2576233002/diff/20001/services/service_manage...
File services/service_manager/runner/host/BUILD.gn (right):

https://codereview.chromium.org/2576233002/diff/20001/services/service_manage...
services/service_manager/runner/host/BUILD.gn:47:
test("mojo_service_process_launcher_unittests") {
If you rename the test suite you also need to update the test configs.

But we actually shouldn't even have this test target, so let's just delete it.
These tests can be rolled into service_manager_unittests.

I guess we can do this before or after this CL lands, but if doing it after,
please change this target name back to mojo_runner_host_unittests for now.

[Jay Civelli, 2016-12-16 17:25:09]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 17:25:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:28:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Jay Civelli, 2016-12-16 17:39:00]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 17:39:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jay Civelli, 2016-12-16 19:35:16]

https://codereview.chromium.org/2576233002/diff/20001/services/service_manage...
File services/service_manager/runner/host/BUILD.gn (right):

https://codereview.chromium.org/2576233002/diff/20001/services/service_manage...
services/service_manager/runner/host/BUILD.gn:47:
test("mojo_service_process_launcher_unittests") {
On 2016/12/15 01:13:45, Ken Rockot wrote:
> If you rename the test suite you also need to update the test configs.
> 
> But we actually shouldn't even have this test target, so let's just delete it.
> These tests can be rolled into service_manager_unittests.
> 
> I guess we can do this before or after this CL lands, but if doing it after,
> please change this target name back to mojo_runner_host_unittests for now.

I merged the mojo_runner_host_unittests to service_manager_unitests.
What test configs do I need to update?

[Jay Civelli, 2016-12-16 19:35:25]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 19:36:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-16 20:26:18]

On 2016/12/16 at 19:35:16, jcivelli wrote:
>
https://codereview.chromium.org/2576233002/diff/20001/services/service_manage...
> File services/service_manager/runner/host/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2576233002/diff/20001/services/service_manage...
> services/service_manager/runner/host/BUILD.gn:47:
test("mojo_service_process_launcher_unittests") {
> On 2016/12/15 01:13:45, Ken Rockot wrote:
> > If you rename the test suite you also need to update the test configs.
> > 
> > But we actually shouldn't even have this test target, so let's just delete
it.
> > These tests can be rolled into service_manager_unittests.
> > 
> > I guess we can do this before or after this CL lands, but if doing it after,
> > please change this target name back to mojo_runner_host_unittests for now.
> 
> I merged the mojo_runner_host_unittests to service_manager_unitests.
> What test configs do I need to update?

Oh, hah! I already removed it from all the bots in anticipation of this merge. I
forgot I did that. Must have been drunk at the time.

[Jay Civelli, 2016-12-16 21:54:44]

jcivelli@chromium.org changed reviewers:
+ sky@chromium.org

[Jay Civelli, 2016-12-16 21:55:02]

Adding @sky for chrome/OWNERS review

[sky, 2016-12-16 23:22:36]

LGTM

[commit-bot: I haz the power, 2016-12-17 00:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 00:22:49]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2016-12-17 00:31:15]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2016-12-17 00:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2576233002/#ps80001
(title: "Merged mojo_runner_host_unittests in service_manager_unittests")

[commit-bot: I haz the power, 2016-12-17 00:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 00:41:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481934675403850,
"parent_rev": "a062685f8d548ecdc5cd6b5ae7c30ea7cb8fcb30", "commit_rev":
"e2a6f7729894d980593e8ff6f53e560cf7f35d66"}

[commit-bot: I haz the power, 2016-12-17 00:41:27]

Description was changed from

==========
Consolidating the functionality offered by NativeRunner by merging the
NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.


BUG=674311
==========

to

==========
Consolidating the functionality offered by NativeRunner by merging the
NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.


BUG=674311

Review-Url: https://codereview.chromium.org/2576233002
==========

[commit-bot: I haz the power, 2016-12-17 00:41:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-17 00:46:01]

Description was changed from

==========
Consolidating the functionality offered by NativeRunner by merging the
NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.


BUG=674311

Review-Url: https://codereview.chromium.org/2576233002
==========

to

==========
Consolidating the functionality offered by NativeRunner by merging the
NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new
ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.

BUG=674311

Committed: https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7
Cr-Commit-Position: refs/heads/master@{#439256}
==========

[commit-bot: I haz the power, 2016-12-17 00:46:02]

Patchset 5 (id:??) landed as
https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7
Cr-Commit-Position: refs/heads/master@{#439256}