Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2576213007: [interpreter] Avoid allocation of temporary array of Nodes when generating dispatch to bytecode han… (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Avoid allocation of temporary array of Nodes when generating dispatch to bytecode handler. BUG= Review-Url: https://codereview.chromium.org/2576213007 Cr-Commit-Position: refs/heads/master@{#41759} Committed: https://chromium.googlesource.com/v8/v8/+/63279611b2917f647da70adbf5423f9c4af45fb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -42 lines) Patch
M src/compiler/code-assembler.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/code-assembler.cc View 2 chunks +13 lines, -19 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-16 11:47:06 UTC) #4
Michael Starzinger
LGTM.
4 years ago (2016-12-16 11:51:55 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2584743003 Patch 60001). Please resolve the dependency and ...
4 years ago (2016-12-16 12:01:44 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2584743003 Patch 60001). Please resolve the dependency and ...
4 years ago (2016-12-16 12:02:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576213007/1
4 years ago (2016-12-16 12:55:50 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 12:58:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/63279611b2917f647da70adbf5423f9c4af...

Powered by Google App Engine
This is Rietveld 408576698