Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2576203004: [Sync] Remove SyncEngine::UnregisterInvalidationIds (Closed)

Created:
4 years ago by maxbogue
Modified:
4 years ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove SyncEngine::UnregisterInvalidationIds It's only called in the KEEP_DATA case in PSS right now. In SBHI we call it in the CLEAR_DATA case, so let's always do what it does there and not expose a method for it. BUG=669967 Committed: https://crrev.com/93c58ecbd5b5a865e1e6e2c3c4ba3b3bc98e5def Cr-Commit-Position: refs/heads/master@{#439549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M components/browser_sync/profile_sync_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +1 line, -9 lines 0 comments Download
M components/sync/engine/fake_sync_engine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine/fake_sync_engine.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine/sync_engine.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
maxbogue
Sky, PTAL!
4 years ago (2016-12-19 15:25:14 UTC) #6
skym
lgtm
4 years ago (2016-12-19 16:49:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576203004/1
4 years ago (2016-12-19 18:05:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88902)
4 years ago (2016-12-19 19:57:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576203004/1
4 years ago (2016-12-19 20:19:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 20:52:40 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-19 20:55:37 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93c58ecbd5b5a865e1e6e2c3c4ba3b3bc98e5def
Cr-Commit-Position: refs/heads/master@{#439549}

Powered by Google App Engine
This is Rietveld 408576698