Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2576163002: Fix _GEN_TEST_CACHE. (Closed)

Created:
4 years ago by iannucci
Modified:
4 years ago
Reviewers:
dnj, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix _GEN_TEST_CACHE. Was looking up a key that would never exist in the cache and so would do way more work than necessary on every test. R=dnj@chromium.org, martiniss@chromium.org BUG=674090 Review-Url: https://codereview.chromium.org/2576163002 Committed: https://github.com/luci/recipes-py/commit/63c1741d42b2e5e77af929cbdf7f69c03f35b627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M recipe_engine/simulation_test.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
iannucci
4 years ago (2016-12-14 23:01:29 UTC) #1
dnj
lgtm
4 years ago (2016-12-14 23:04:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576163002/1
4 years ago (2016-12-14 23:07:38 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-14 23:12:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/63c1741d42b2e5e77af929cbdf7f69c03f3...

Powered by Google App Engine
This is Rietveld 408576698