chromeos: Remove OS ifdefs from ash/common/system/tray

chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773, 665960
TEST=ash_unittests
R=msw@chromium.org

Committed: https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5
Cr-Commit-Position: refs/heads/master@{#438706}

[James Cook, 2016-12-14 22:40:59]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:41:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-12-14 22:41:28]

msw, please take a look.

[msw, 2016-12-14 22:51:00]

neat! lgtm with nits

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:324: AddTrayItem(new PaddingTrayItem());
optional nit: fold into the end of the |if (use_md)| conditional on 313

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:518: base::string16 time =
GetAccessibleTimeString(base::Time::Now());
optional nit: inline locals into the function call below.

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_notifier.cc (right):

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_notifier.cc:63: void
SystemTrayNotifier::AddEnterpriseDomainObserver(
nit: this belongs below with the other enterprise functions.

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_unittest.cc (left):

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_unittest.cc:124: // TODO(bruthig): Re-enable.
 See https://crbug.com/665960.
optional nit: cite # in BUG= (doesn't really matter, it's already closed)

[commit-bot: I haz the power, 2016-12-14 23:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 23:25:04]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-12-14 23:42:03]

Description was changed from

==========
chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773
TEST=ash_unittests
R=msw@chromium.org
==========

to

==========
chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773,665960
TEST=ash_unittests
R=msw@chromium.org
==========

[James Cook, 2016-12-14 23:46:09]

Thanks for the quick review.

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:324: AddTrayItem(new PaddingTrayItem());
On 2016/12/14 22:51:00, msw wrote:
> optional nit: fold into the end of the |if (use_md)| conditional on 313

Done.

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:518: base::string16 time =
GetAccessibleTimeString(base::Time::Now());
On 2016/12/14 22:51:00, msw wrote:
> optional nit: inline locals into the function call below.

I tried it and it seemed less readable (the wrapping was bad) so kept as-is.

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_notifier.cc (right):

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_notifier.cc:63: void
SystemTrayNotifier::AddEnterpriseDomainObserver(
On 2016/12/14 22:51:00, msw wrote:
> nit: this belongs below with the other enterprise functions.

Gack. Thanks for catching this.

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray_unittest.cc (left):

https://codereview.chromium.org/2576133002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray_unittest.cc:124: // TODO(bruthig): Re-enable.
 See https://crbug.com/665960.
On 2016/12/14 22:51:00, msw wrote:
> optional nit: cite # in BUG= (doesn't really matter, it's already closed)

Done.

[James Cook, 2016-12-14 23:46:14]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-12-14 23:46:15]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2576133002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-12-14 23:46:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:32:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481759174865400,
"parent_rev": "88b497213f8e78bb75727804e0047a3bd9e88a3b", "commit_rev":
"1e4d08be392bb9e329590fb8897c7072d0bf8028"}

[commit-bot: I haz the power, 2016-12-15 01:33:44]

Description was changed from

==========
chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773,665960
TEST=ash_unittests
R=msw@chromium.org
==========

to

==========
chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773,665960
TEST=ash_unittests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576133002
==========

[commit-bot: I haz the power, 2016-12-15 01:33:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-15 01:35:55]

Description was changed from

==========
chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773,665960
TEST=ash_unittests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576133002
==========

to

==========
chromeos: Remove OS ifdefs from ash/common/system/tray

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773,665960
TEST=ash_unittests
R=msw@chromium.org

Committed: https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5
Cr-Commit-Position: refs/heads/master@{#438706}
==========

[commit-bot: I haz the power, 2016-12-15 01:35:55]

Patchset 2 (id:??) landed as
https://crrev.com/b9c4af6ad8f80e709fbaf9041cc68b6ee8acfbd5
Cr-Commit-Position: refs/heads/master@{#438706}