Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2576103002: [ios] Adds specific_include_rules to DEPS files. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
CC:
chromium-reviews, msramek+watch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, markusheintz_, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds specific_include_rules to DEPS files. BUG=665969 Committed: https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c Cr-Commit-Position: refs/heads/master@{#438885}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Commas are important. #

Patch Set 3 : Review. #

Patch Set 4 : Missed a few #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -0 lines) Patch
M ios/chrome/app/DEPS View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/app/application_delegate/DEPS View 1 chunk +12 lines, -0 lines 0 comments Download
A ios/chrome/app/startup/DEPS View 1 chunk +9 lines, -0 lines 0 comments Download
A ios/chrome/browser/autofill/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/browsing_data/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/metrics/DEPS View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A ios/chrome/browser/native_app_launcher/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/sessions/DEPS View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/snapshots/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/tabs/DEPS View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/DEPS View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/contextual_search/DEPS View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/history/DEPS View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/ntp/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/side_swipe/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/stack_view/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tab_switcher/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/DEPS View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
rohitrao (ping after 24h)
4 years ago (2016-12-14 21:57:37 UTC) #3
Eugene But (OOO till 7-30)
lgtm! https://codereview.chromium.org/2576103002/diff/1/ios/chrome/browser/DEPS File ios/chrome/browser/DEPS (right): https://codereview.chromium.org/2576103002/diff/1/ios/chrome/browser/DEPS#newcode117 ios/chrome/browser/DEPS:117: specific_include_rules = { I think we don't need ...
4 years ago (2016-12-14 22:03:00 UTC) #7
rohitrao (ping after 24h)
https://codereview.chromium.org/2576103002/diff/1/ios/chrome/browser/DEPS File ios/chrome/browser/DEPS (right): https://codereview.chromium.org/2576103002/diff/1/ios/chrome/browser/DEPS#newcode117 ios/chrome/browser/DEPS:117: specific_include_rules = { On 2016/12/14 22:02:59, Eugene But wrote: ...
4 years ago (2016-12-15 02:47:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576103002/80001
4 years ago (2016-12-15 18:47:14 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-15 18:59:43 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-15 19:02:06 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f615b0af7fea1d9dfb86e33a036ca08252b7ce9c
Cr-Commit-Position: refs/heads/master@{#438885}

Powered by Google App Engine
This is Rietveld 408576698