Fixes bug where shelf items could be added for children windows

Fixes bug where shelf items could be added for children windows

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org

Committed: https://crrev.com/fbdca2cd589d89e0c99eecb3cb194eb47bbabbb1
Cr-Commit-Position: refs/heads/master@{#438622}

[msw, 2016-12-14 20:42:28]

lgtm, thanks for catching this!

[sky, 2016-12-14 20:42:42]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:43:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:15:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481748162626630, "parent_rev":
"f8df0c78b4c18414656f9f97b9b32a74dc41d2c4", "commit_rev":
"5faf1f1bb86b6efeea9f88842f5d293e2d3838cd"}

[commit-bot: I haz the power, 2016-12-14 21:15:46]

Description was changed from

==========
Fixes bug where shelf items could be added for children windows

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org
==========

to

==========
Fixes bug where shelf items could be added for children windows

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576023002
==========

[commit-bot: I haz the power, 2016-12-14 21:15:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 21:19:43]

Description was changed from

==========
Fixes bug where shelf items could be added for children windows

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576023002
==========

to

==========
Fixes bug where shelf items could be added for children windows

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org

Committed: https://crrev.com/fbdca2cd589d89e0c99eecb3cb194eb47bbabbb1
Cr-Commit-Position: refs/heads/master@{#438622}
==========

[commit-bot: I haz the power, 2016-12-14 21:19:44]

Patchset 1 (id:??) landed as
https://crrev.com/fbdca2cd589d89e0c99eecb3cb194eb47bbabbb1
Cr-Commit-Position: refs/heads/master@{#438622}