Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: syzygy/agent/asan/runtime.h

Issue 2576003002: Add the ability to defer the initialization of the SyzyAsan crash reporter. (Closed)
Patch Set: x64 def file. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: syzygy/agent/asan/runtime.h
diff --git a/syzygy/agent/asan/runtime.h b/syzygy/agent/asan/runtime.h
index 2336e82a3cdc41ac4e93c774328f47e38866c4e0..e5a7a2ef5e328983b6035764ffd530c6ba2e76f0 100644
--- a/syzygy/agent/asan/runtime.h
+++ b/syzygy/agent/asan/runtime.h
@@ -149,6 +149,9 @@ class AsanRuntime {
// @names Accessors.
// {
uint64_t random_key() const { return random_key_; }
+ bool crash_reporter_initialized() const {
+ return crash_reporter_initialized_;
+ }
// @}
// Observes a given thread ID, adding it to thread ID set.
@@ -194,6 +197,9 @@ class AsanRuntime {
// @returns the list of enabled features.
AsanFeatureSet GetEnabledFeatureSet();
+ // Initialize the crash reporter used by the runtime.
chrisha 2017/01/11 18:57:28 More comments about how this is related to the def
Sébastien Marchand 2017/01/11 21:38:08 Done.
+ void InitializeCrashReporter();
+
protected:
// Propagate the values of the flags to the target modules.
void PropagateParams();
@@ -327,6 +333,9 @@ class AsanRuntime {
// is available.
std::unique_ptr<ReporterInterface> crash_reporter_;
+ // Indicates if the crash reporter has been initialized.
+ bool crash_reporter_initialized_;
+
DISALLOW_COPY_AND_ASSIGN(AsanRuntime);
};

Powered by Google App Engine
This is Rietveld 408576698