Add the ability to defer the initialization of the SyzyAsan crash reporter.

syzygy/agent/asan/runtime.h

 // Copyright 2012 Google Inc. All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 131 matching lines @@
 
   // Sets the allocation-filter flag to the specified value.
   // @param value the new value for the flag.
   // @note The flag is stored per-thread using TLS. Multiple threads do not
   //     share the same flag.
   void set_allocation_filter_flag(bool value);
 
   // @names Accessors.
   // {
   uint64_t random_key() const { return random_key_; }
+  bool crash_reporter_initialized() const {
+    return crash_reporter_initialized_;
+  }
   // @}
 
   // Observes a given thread ID, adding it to thread ID set.
   // @param thread_id The thread ID that has been observed.
   void AddThreadId(uint32_t thread_id);
 
   // Determines if a thread ID has already been seen.
   // @param thread_id The thread ID to be queried.
   // @returns true if a given thread ID is valid for this process.
   bool ThreadIdIsValid(uint32_t thread_id);
@@ skipping 25 matching lines @@
 
   // Enables the deferred free thread.
   void EnableDeferredFreeThread();
 
   // Disables the deferred free thread.
   void DisableDeferredFreeThread();
 
   // @returns the list of enabled features.
   AsanFeatureSet GetEnabledFeatureSet();
 
+  // Initialize the crash reporter used by the runtime.

[chrisha, 2017/01/11 18:57:28]

More comments about how this is related to the deferred initialization flag.
What happens if I call this after it's already initialized? If the flag isn't
specified, etc? Detail the "contract" associated with use of this function.

[Sébastien Marchand, 2017/01/11 21:38:08]

Done.

+  void InitializeCrashReporter();
+
  protected:
   // Propagate the values of the flags to the target modules.
   void PropagateParams();
 
   // @returns the space required to write the provided corrupt heap info.
   // @param corrupt_ranges The corrupt range info.
   size_t CalculateCorruptHeapInfoSize(
       const HeapChecker::CorruptRangesVector& corrupt_ranges);
 
   // Writes corrupt heap information to the provided buffer. This will write
@@ skipping 113 matching lines @@
   std::unordered_set<uint32_t> thread_ids_;  // Under thread_ids_lock_.
 
   // A random key that is generated on object creation. This is used for
   // correlating duplicate crash reports on the back-end.
   const uint64_t random_key_;
 
   // The crash reporter in use. This will be left null if no crash reporter
   // is available.
   std::unique_ptr<ReporterInterface> crash_reporter_;
 
+  // Indicates if the crash reporter has been initialized.
+  bool crash_reporter_initialized_;
+
   DISALLOW_COPY_AND_ASSIGN(AsanRuntime);
 };
 
 }  // namespace asan
 }  // namespace agent
 
 #endif  // SYZYGY_AGENT_ASAN_RUNTIME_H_