third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl - Issue 2575943002: Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl

Issue 2575943002: Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp ('K') | « third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp ('k') | third_party/WebKit/public/platform/modules/shapedetection/barcodedetection.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl

diff --git a/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl b/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl

index 7875f6acb706d20912856703bce995da08d1bbc1..9ef3342792b74fe728434af64c328b0fec209495 100644

--- a/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl

+++ b/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl

@@ -10,5 +10,9 @@

] interface DetectedBarcode {

// TODO(mcasas): Implement missing fields. https://crbug.com/646083

[SameObject] readonly attribute DOMString rawValue;

+ // |x|, |y| refer to the coordinates of the bottom-left corner.

mcasas 2016/12/15 19:01:58 Who are |x| and |y| inside |boundingBox| ?

xianglu 2016/12/16 00:01:25 I meant to say that boundingBox and cornerPoints s

[SameObject] readonly attribute DOMRect boundingBox;

+ // 4 corner points in clockwise direction starting with bottom-left. Due to

+ // possible perspective distortions, this is not necessarily a rectangle.

+ [SameObject] readonly attribute sequence<Point2D> cornerPoints;

};