third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl - Issue 2575943002: Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl

Issue 2575943002: Barcode Detection: Add |cornerPoints| to DetectedBarcode.idl (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp ('K') | « third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.cpp ('k') | third_party/WebKit/public/platform/modules/shapedetection/barcodedetection.mojom » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://wicg.github.io/shape-detection-api/#barcode-detection-api	5 // https://wicg.github.io/shape-detection-api/#barcode-detection-api

6	6

7 [	7 [

8 Constructor,	8 Constructor,

9 RuntimeEnabled=ShapeDetection,	9 RuntimeEnabled=ShapeDetection,

10 ] interface DetectedBarcode {	10 ] interface DetectedBarcode {

11 // TODO(mcasas): Implement missing fields. https://crbug.com/646083	11 // TODO(mcasas): Implement missing fields. https://crbug.com/646083

12 [SameObject] readonly attribute DOMString rawValue;	12 [SameObject] readonly attribute DOMString rawValue;

	13 // \|x\|, \|y\| refer to the coordinates of the bottom-left corner.
	mcasas 2016/12/15 19:01:58 Who are \|x\| and \|y\| inside \|boundingBox\| ? Who are \|x\| and \|y\| inside \|boundingBox\| ? xianglu 2016/12/16 00:01:25 I meant to say that boundingBox and cornerPoints s Show quoted text On 2016/12/15 19:01:58, mcasas wrote: > Who are \|x\| and \|y\| inside \|boundingBox\| ? I meant to say that boundingBox and cornerPoints shared the same setup. But it is actually DOMRect's feature anyway. Removed.
13 [SameObject] readonly attribute DOMRect boundingBox;	14 [SameObject] readonly attribute DOMRect boundingBox;

	15 // 4 corner points in clockwise direction starting with bottom-left. Due to

	16 // possible perspective distortions, this is not necessarily a rectangle.

	17 [SameObject] readonly attribute sequence<Point2D> cornerPoints;

14 };	18 };

OLD	NEW