Issue 2575923002: Make sure pages that are closing but not yet closed are still suspended (non-preferred approach).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2575923002: Make sure pages that are closing but not yet closed are still suspended (non-preferred approach). (Closed)

Created:
4 years ago by dcheng

Modified:
3 years, 12 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, kinuko+watch

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make sure pages that are closing but not yet closed are still suspended (non-preferred approach). BUG=671102

Patch Set 1 #

Patch Set 2 : . #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -19 lines)			Patch
M	third_party/WebKit/Source/core/page/Page.h	View		4 chunks	+14 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/page/Page.cpp	View		3 chunks	+13 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/page/ScopedPageSuspender.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp	View		2 chunks	+15 lines, -9 lines	0 comments	Download
M	third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/web/tests/WebViewTest.cpp	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dcheng

Description was changed from ========== Ensure that pages that are closing are still deferred. BUG=671102 ...

4 years ago (2016-12-15 11:22:04 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575923002/20001

4 years ago (2016-12-15 11:23:05 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years ago (2016-12-15 12:47:44 UTC) #4

commit-bot: I haz the power

4 years ago (2016-12-15 12:47:45 UTC) #5

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages