Make item getter and nameditem getter return nullable in Plugin and PluginArray

Make item getter and nameditem getter return nullable in Plugin and PluginArray

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005
Committed: https://crrev.com/49512757a40ff27cc36b9a92dd09ac8c14687909
Cr-Commit-Position: refs/heads/master@{#438568}

[lunalu1, 2016-12-14 17:01:24]

The CQ bit was checked by lunalu@chromium.org to run a CQ dry run

[lunalu1, 2016-12-14 17:01:53]

lunalu@chromium.org changed reviewers:
+ foolip@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-12-14 17:02:47]

lgtm

[commit-bot: I haz the power, 2016-12-14 17:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:12:43]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lunalu1, 2016-12-14 17:42:16]

The CQ bit was checked by lunalu@chromium.org

[commit-bot: I haz the power, 2016-12-14 17:42:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:05:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481737336698890,
"parent_rev": "db4863710c65faa00e392092b276e82026b8b354", "commit_rev":
"dc6e0e7012d5fc4eb797ddec3754bfc3196ad441"}

[commit-bot: I haz the power, 2016-12-14 19:06:16]

Description was changed from

==========
Make item getter and nameditem getter return nullable in Plugin and PluginArray

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005
==========

to

==========
Make item getter and nameditem getter return nullable in Plugin and PluginArray

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005

Review-Url: https://codereview.chromium.org/2575893002
==========

[commit-bot: I haz the power, 2016-12-14 19:06:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 19:08:28]

Description was changed from

==========
Make item getter and nameditem getter return nullable in Plugin and PluginArray

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005

Review-Url: https://codereview.chromium.org/2575893002
==========

to

==========
Make item getter and nameditem getter return nullable in Plugin and PluginArray

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2

BUG=662005

Committed: https://crrev.com/49512757a40ff27cc36b9a92dd09ac8c14687909
Cr-Commit-Position: refs/heads/master@{#438568}
==========

[commit-bot: I haz the power, 2016-12-14 19:08:29]

Patchset 2 (id:??) landed as
https://crrev.com/49512757a40ff27cc36b9a92dd09ac8c14687909
Cr-Commit-Position: refs/heads/master@{#438568}

[foolip, 2016-12-14 19:19:45]

https://codereview.chromium.org/2575893002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/plugins/PluginArray.idl (right):

https://codereview.chromium.org/2575893002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/plugins/PluginArray.idl:29: [NotEnumerable,
ImplementedAs=namedItem] getter Plugin ([Default=Undefined] optional DOMString
name);
Oops, both there and in the other file we missed the third instance that should
be made nullable even if not in spec. Can you follow up and also add TODOs
saying something like "the namedItem method and anonymous named getter should be
merged"?