Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2575893002: Make item getter and nameditem getter return nullable in Plugin and PluginArray (Closed)

Created:
4 years ago by lunalu1
Modified:
4 years ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make item getter and nameditem getter return nullable in Plugin and PluginArray Spec: https://html.spec.whatwg.org/multipage/webappapis.html#plugins-2 BUG=662005 Committed: https://crrev.com/49512757a40ff27cc36b9a92dd09ac8c14687909 Cr-Commit-Position: refs/heads/master@{#438568}

Patch Set 1 #

Patch Set 2 : Added links to the spec #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/plugins/Plugin.idl View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/PluginArray.idl View 1 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (9 generated)
lunalu1
4 years ago (2016-12-14 17:01:54 UTC) #3
foolip
lgtm
4 years ago (2016-12-14 17:02:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575893002/20001
4 years ago (2016-12-14 17:42:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 19:06:17 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/49512757a40ff27cc36b9a92dd09ac8c14687909 Cr-Commit-Position: refs/heads/master@{#438568}
4 years ago (2016-12-14 19:08:29 UTC) #14
foolip
4 years ago (2016-12-14 19:19:45 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2575893002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/plugins/PluginArray.idl (right):

https://codereview.chromium.org/2575893002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/plugins/PluginArray.idl:29: [NotEnumerable,
ImplementedAs=namedItem] getter Plugin ([Default=Undefined] optional DOMString
name);
Oops, both there and in the other file we missed the third instance that should
be made nullable even if not in spec. Can you follow up and also add TODOs
saying something like "the namedItem method and anonymous named getter should be
merged"?

Powered by Google App Engine
This is Rietveld 408576698