Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2575863002: Ignore minimum font-size for SVG text (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
pdr.
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore minimum font-size for SVG text In some circumstances, the minimum font-size would be applied to the "scaled font", messing up rendering. Because of how the font is scaled, this would trigger much less than one might expect. Change the useSmartMinimumForFontSize argument to the FontSize::getComputedSizeFromSpecifiedSize function to be about entirely ignoring the minimum font-sizes (this function only has two callsites.) Refactor LayoutSVGInlineText::computeNewScaledFontForStyle a bit to deal with this new flow. Also always keep the "original" font when we compute a scale factor of 0 - it should be invisible regardless. BUG=232332, 335725, 475795, 626936, 664961 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/94ccfef1071cee24bbe7125d79704a504c41106a Cr-Commit-Position: refs/heads/master@{#438794}

Patch Set 1 #

Messages

Total messages: 17 (12 generated)
fs
I didn't expect this to sail through the trybots so easily, but hey, who am ...
4 years ago (2016-12-14 17:31:59 UTC) #9
pdr.
Hey that was easy. Nice! LGTM
4 years ago (2016-12-14 21:58:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575863002/1
4 years ago (2016-12-15 09:42:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 09:46:36 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-15 09:48:52 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94ccfef1071cee24bbe7125d79704a504c41106a
Cr-Commit-Position: refs/heads/master@{#438794}

Powered by Google App Engine
This is Rietveld 408576698