Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2575843002: Cleanup //ios/chrome/browser/prefs dependencies. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup //ios/chrome/browser/prefs dependencies. Downstream code has been updated to use correct dependencies, so remove this temporary public_deps. BUG=None Committed: https://crrev.com/e3f9639088ddccaedd212a4e6771dd575578c61e Cr-Commit-Position: refs/heads/master@{#439352}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ios/chrome/browser/prefs/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
sdefresne
Please take a look.
4 years ago (2016-12-14 14:51:13 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-14 14:55:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575843002/20001
4 years ago (2016-12-17 19:39:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-17 20:54:10 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-17 20:56:50 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3f9639088ddccaedd212a4e6771dd575578c61e
Cr-Commit-Position: refs/heads/master@{#439352}

Powered by Google App Engine
This is Rietveld 408576698