Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2575823003: Fixing histogram logging to better track variations headers https change. (Closed)

Created:
4 years ago by jwd
Modified:
4 years ago
Reviewers:
rkaplow
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing histogram logging to better track variations headers https change. BUG=672950 Committed: https://crrev.com/a32d49767933c8642a9e4425b32f93bbbb7ef2c5 Cr-Commit-Position: refs/heads/master@{#438605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M components/variations/net/variations_http_headers.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
jwd
4 years ago (2016-12-14 17:57:27 UTC) #3
rkaplow
lgtm
4 years ago (2016-12-14 19:28:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575823003/1
4 years ago (2016-12-14 20:12:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 20:21:42 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 20:24:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a32d49767933c8642a9e4425b32f93bbbb7ef2c5
Cr-Commit-Position: refs/heads/master@{#438605}

Powered by Google App Engine
This is Rietveld 408576698