Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2575823002: [Popular Sites] Move PopularSitesImpl to dedicated file (Closed)

Created:
4 years ago by mastiz
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), ntp-dev+reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Popular Sites] Move PopularSitesImpl to dedicated file Trivial follow-up to https://codereview.chromium.org/2570783003/ where it was suggested to move the new class to a dedicated file. BUG=619584 Committed: https://crrev.com/b06f14242378cb8ce63fd7ee3ec89d4287757c49 Cr-Commit-Position: refs/heads/master@{#438811}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Added missing forward declaration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -883 lines) Patch
M chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_tiles/popular_sites.h View 1 2 chunks +0 lines, -95 lines 0 comments Download
D components/ntp_tiles/popular_sites.cc View 1 1 chunk +0 lines, -398 lines 0 comments Download
A + components/ntp_tiles/popular_sites_impl.h View 1 4 chunks +5 lines, -53 lines 0 comments Download
A + components/ntp_tiles/popular_sites_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/ntp_tiles/popular_sites_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/ntp_tiles/popular_sites_unittest.cc View 1 chunk +0 lines, -329 lines 0 comments Download
M ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
mastiz
bauerb@chromium.org: Please review changes in all dirs except ios/ sdefresne@chromium.org: Please review changes in ios/
4 years ago (2016-12-14 20:16:24 UTC) #2
sdefresne
lgtm (reviewed everything, sorry)
4 years ago (2016-12-15 10:43:38 UTC) #3
Bernhard Bauer
lgtm
4 years ago (2016-12-15 11:18:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575823002/20001
4 years ago (2016-12-15 11:19:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/123466) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-15 11:23:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575823002/40001
4 years ago (2016-12-15 11:31:48 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 12:32:53 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-15 12:34:47 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b06f14242378cb8ce63fd7ee3ec89d4287757c49
Cr-Commit-Position: refs/heads/master@{#438811}

Powered by Google App Engine
This is Rietveld 408576698