Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2575803002:
Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong (Closed)
|
Created:
4 years ago by hajimehoshi Modified:
3 years, 7 months ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong
TranferBufferManager takes buffers whose backing store might or might
not be SharedMemory, but accumulates shared memory usage no matter what
the buffer is. This CL fixes this to make TranferBufferManager count
shared memory usage only when the buffer's backing store is
SharedMemory.
BUG=604726
TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/6c8897721e2df9a0ec3677d0a13d677c457e5e1e
Cr-Commit-Position: refs/heads/master@{#439419}
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
Description was changed from ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* ========== to ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hajimehoshi@chromium.org changed reviewers: + jbauman@chromium.org, primiano@chromium.org
PTAL
Description was changed from ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hajimehoshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482126110938100, "parent_rev":
"495a672b011f109949e4f5aca658f9b874beea97", "commit_rev":
"5f59f1a23694f138f25131e0befbe1d7ecba580c"}
Message was sent while issue was closed.
Description was changed from ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2575803002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2575803002 ========== to ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6c8897721e2df9a0ec3677d0a13d677c457e5e1e Cr-Commit-Position: refs/heads/master@{#439419} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6c8897721e2df9a0ec3677d0a13d677c457e5e1e Cr-Commit-Position: refs/heads/master@{#439419}
Message was sent while issue was closed.
Description was changed from ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6c8897721e2df9a0ec3677d0a13d677c457e5e1e Cr-Commit-Position: refs/heads/master@{#439419} ========== to ========== Bug fix: TranferBufferManager's SharedMemory memory usage reporting was wrong TranferBufferManager takes buffers whose backing store might or might not be SharedMemory, but accumulates shared memory usage no matter what the buffer is. This CL fixes this to make TranferBufferManager count shared memory usage only when the buffer's backing store is SharedMemory. BUG=604726 TEST=gpu_unittests --gtest_filter=TransferBufferManagerTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6c8897721e2df9a0ec3677d0a13d677c457e5e1e Cr-Commit-Position: refs/heads/master@{#439419} ==========
Message was sent while issue was closed.
hajimehoshi@chromium.org changed reviewers: + ericrk@chromium.org
Message was sent while issue was closed.
+ericrk This CL removes a global shared dump and an edge to it when the back end is not base::SharedMemory. However, as we discussed at https://codereview.chromium.org/2866973003/, I understood the global shared dump are needed regardless of back end. Do you think this CL should be reverted? Thanks.
Message was sent while issue was closed.
hajimehoshi@chromium.org changed reviewers: + ssid@chromium.org
Message was sent while issue was closed.
On 2017/05/24 03:42:30, hajimehoshi wrote: > +ericrk > > This CL removes a global shared dump and an edge to it when the back end is not > base::SharedMemory. However, as we discussed at > https://codereview.chromium.org/2866973003/, I understood the global shared dump > are needed regardless of back end. Do you think this CL should be reverted? > Thanks. As ssid@ and I discussed, we are going to revert this. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
