Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2575793002: [NTP::RecentTabs] Cleanup: remove OfflinePageProxy from a comment. (Closed)

Created:
4 years ago by vitaliii
Modified:
4 years ago
Reviewers:
jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::RecentTabs] Cleanup: remove OfflinePageProxy from a comment. OfflinePageProxy class has need removed, but a mention of it in a comment remained. This CL removes it completely. BUG=672432 Committed: https://crrev.com/d2bb1e88408e01e1af321ebe7d83125659605b08 Cr-Commit-Position: refs/heads/master@{#438480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
vitaliii
[nano CL - 1 line] Hi jkrcal@, could you have a look at my 1 ...
4 years ago (2016-12-14 10:24:49 UTC) #4
jkrcal
lgtm, thanks for brevity! ;)
4 years ago (2016-12-14 10:27:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575793002/1
4 years ago (2016-12-14 10:29:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 11:22:25 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-14 11:25:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2bb1e88408e01e1af321ebe7d83125659605b08
Cr-Commit-Position: refs/heads/master@{#438480}

Powered by Google App Engine
This is Rietveld 408576698