Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 2575743002: MD Settings: clicking on the "Learn more" shouldn't select the sync passphrase option (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: clicking on the "Learn more" shouldn't select the sync passphrase option It should only open the learn more link. R=tommycli@chromium.org BUG=621702 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b161e6dc940704d74f8f60aa38431f22b4e9807f Cr-Commit-Position: refs/heads/master@{#438710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/sync_page.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Dan Beam
4 years ago (2016-12-14 04:36:29 UTC) #2
tommycli
lgtm
4 years ago (2016-12-14 22:02:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575743002/1
4 years ago (2016-12-15 00:25:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 01:37:29 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 01:41:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b161e6dc940704d74f8f60aa38431f22b4e9807f
Cr-Commit-Position: refs/heads/master@{#438710}

Powered by Google App Engine
This is Rietveld 408576698